search

ponylang / ponyc

Pony is an open-source, actor-model, capabilities-secure, high performance programming language
http://www.ponylang.io
BSD 2-Clause "Simplified" License
5.69k stars 410 forks source link

String.f32 and f64 should be implemented in Pony. #1449

Open jemc opened 7 years ago

jemc commented 7 years ago

Currently String.f32 and f64 use the strtof FFI call internally.

As discussed on the sync call, it would be desirable for us to implement this in pure Pony instead of relying on the C call for something we can do ourselves in a more transparent, debuggable way.

This change should have no impact on the user, so it doesn't need an RFC - it just needs someone to step up and do the implementation.

laucer commented 7 years ago

Hey @jemc, I would like to carry out this task

jemc commented 7 years ago

@laucer - Thanks for stepping up!

I've sent you an invite to the ponylang organization, so that you can be assigned to this issue ticket after you accept the invitation.

jemc commented 7 years ago

@laucer - Thanks for accepting the invite - I've assigned you to this ticket. Let us know if you have any questions about it.

Thanks!

kcrimson commented 7 years ago

it means we can close #1445 as "won't do", as I understand this ticket solves problem with calling strtof

jemc commented 7 years ago

@kcrimson - I left it open, as I was anticipating that this ticket might take a long time to complete, and the fix suggested in #1445 is pretty trivial. The way I see it, #1445 fixes the immediate problem of not using cstring as we should be, and this ticket is a more long-term effort to replace the strtof call entirely.