raise instead of falling through on unknown desc arg

ponyorm / pony

Pony Object Relational Mapper

Apache License 2.0

3.65k stars 245 forks source link

raise instead of falling through on unknown desc arg #651

Closed nburns closed 2 years ago

nburns commented 2 years ago

Raising instead of returning the original value is much safer and gives users the ability to know when the arg passed to desc is not handled, instead of silently ignoring the intent.

Fix for: https://github.com/ponyorm/pony/issues/646

nburns commented 2 years ago

I wasn't sure how to run the tests, pytest after clone kinda worked but some instructions/help on contributing would be great.

nburns commented 2 years ago

closing this because of no response, the issue is still valid