search

poohcom1 / godot-animated-sprite-2-player

A Godot addon to convert animated sprite frames to animations in an animation player.
https://godotengine.org/asset-library/asset/1605
MIT License
41 stars 3 forks source link

Support Sprite Frames individual Frame Duration multiplier #6

Closed hsandt closed 1 year ago

hsandt commented 1 year ago

For demonstration, set the Frame Duration of the first two frames of the attack animation to x1.5

Fixes #5

hsandt commented 1 year ago

As a side note, I tried to keep whitespaces in big blocks but not between big blocks. However the formatting rule is not too clear. May I strip all whitespaces next time, using the text_editor/behavior/files/trim_trailing_whitespace_on_save setting?

poohcom1 commented 1 year ago

Dang, that was fast! Thanks, I'll take a look.

For the formatting, you can go just ahead and strip, I think that'll be better too.

poohcom1 commented 1 year ago

LGTM! I'll merge now so I can update the addon on the asset library as soon as possible.

As for the formatting, you can create another PR or just wait until next time. I'll actually add you as a collaborator since you've contributed a lot and you probably use this addon more than me now xD. If are okay with that, then you're free to format or add other features (or still create PRs if you prefer).

hsandt commented 1 year ago

Thanks, I accepted the invite. I'll format next time I do some changes.

You're right, I'm using the importer a lot, it really improves my workflow when working directly from a spritesheet and tuning the FPS. If I have an idea for another feature (like hybrid track preserve mode), I'll open an issue and start working on it.