search

poohsen / thunderlink

Link to your Thunderbird emails!
Mozilla Public License 2.0
19 stars 4 forks source link

Recent merges #29

Open simonthum opened 8 years ago

simonthum commented 8 years ago

Hi,

please not that my PR #25, since it came from master, got updated to contain lots of stuff that perhaps shouldn't have been merged. Notably, I added a -simon to the version to avoid ambiguities and added packaged versions thereof.

You may want to get rid of that.

poohsen commented 8 years ago

I'm not bothered by that .xpi file. The other commits looked fine at first glance. Is there anything I need to look at specifically? I wanted to take some time to test yesterday but ended up wasting it on Ubuntu compiz issues when running in vbox. This has been one of the reasons why I haven't been actively developing TL: I Can't setup a working testing env on my macbook...

simonthum commented 8 years ago

Well, the XPI is probably OK but the version string got a "-simon" from me so I'd know what's going on from the Addons Tab. This will end up on AMO if you don't remove it, and I don't feel like having done such a great job here to deserve a designation ;)

Anyway, the plugin XPI works for me, without regressions AFAICT, so the xpi should be fine.

poohsen commented 8 years ago

how so? the repo isn't linked to mozilla in any way suitable for automatic pulling of XPIs. I upload new versions to AMO manually when they're done, so no problem there. Unless I missed some cool new AMO feature

simonthum commented 8 years ago

Not automatically, but see

https://github.com/poohsen/thunderlink/blame/master/install.rdf#L7

poohsen commented 8 years ago

ah yes. that's right. I missed that change in the diff. thx!