pookjw / NightPatch

Enable Night Shift on any old Mac models.
Apache License 2.0
79 stars 8 forks source link

High Sierra not working. #3

Open Squuiid opened 6 years ago

Squuiid commented 6 years ago

Unfortunately NightPatch is not working with the GM release of High Sierra. Is there any chance of an updated binary? Thank you!

aonez commented 6 years ago

Could you try this alternative until @pookjw makes its version?

https://github.com/aonez/NightShiftPatcher

Squuiid commented 6 years ago

Thank you very much! I will give it a go.

On 3 Oct 2017, at 16:57, aONe notifications@github.com<mailto:notifications@github.com> wrote:

Could you try this alternative until @pookjwhttps://github.com/pookjw makes its version?

https://github.com/aonez/NightShiftPatcher

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/pookjw/NightPatch/issues/3#issuecomment-333887935, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ae4-OyU-Wv0R43UvMVQRjH05H6r2Q9AQks5sollSgaJpZM4PsWj3.

JimmyPastel commented 6 years ago

Could you try this alternative until @pookjw makes its version?

https://github.com/aonez/NightShiftPatcher

Perfectly working!! iMac 2011 macOS hight Sierra.

Thank you!!

pookjw commented 6 years ago

Updated to support for High Sierra. Thanks @aonez.

https://github.com/pookjw/NightPatch/commit/6f1953b61cae9f4ff028e0dec6d0daca4e53d50f

Squuiid commented 6 years ago

@pookjw, this has the same issue as @aonez. You need to have the user install Xcode tools BEFORE running your tool.

$ cd /tmp; curl -s -o NightPatch.zip https://codeload.github.com/pookjw/NightPatch/zip/master; unzip -o -qq NightPatch.zip; cd NightPatch-master; chmod +x NightPatch.sh; ./NightPatch.sh Password: Creating backup... Patching... xcode-select: note: no developer tools were found at '/Applications/Xcode.app', requesting install. Choose an option in the dialog to download the command line developer tools. dd: seek: Invalid argument Done. Reboot your macOS.

pookjw commented 6 years ago

@Squuiid added instruction to script

https://github.com/pookjw/NightPatch/commit/c6a7675657a08c571a7dad7a8645a2ae6d5debea

Squuiid commented 6 years ago

@pookjw Might it be better to run nm with no arguments at the beginning of the script to call the Xcode tools install (most won't have this installed) and pause until it has installed, then run the rest of the script to enable Night Shift? Would that be possible? (I'm no coder!)

pookjw commented 6 years ago

@Squuiid reflected your opinion to https://github.com/pookjw/NightPatch/commit/b85b8b23611057a1ed15f0a1ad621c040810d684. But my macOS has already installed Command Line Tool, so I can't test this. You can test this by using --test option. Could you test this?

Squuiid commented 6 years ago

@pookjw thank you very much! I too now have the tools installed but will rebuild a Mac tonight and give it ago and report back. Very grateful for you efforts.