pookjw / NightPatch

Enable Night Shift on any old Mac models.
Apache License 2.0
79 stars 8 forks source link

high sierra 10.13.4 no support - fatal error #5

Open jnetshaw opened 6 years ago

jnetshaw commented 6 years ago

time to update your stuff dude cause 10.13.4 would not boot and needs to reinstall let alone would not revert - complete headache..

mandril420 commented 6 years ago

I’m having the same issue. Now my Mac Pro with 10.13.4 will not boot!! How do I fix this without reinstalling the OS?

aonez commented 6 years ago

@mandril420 boot into recovery mode and in the terminal replace the modified file with the backup.

This is the file in question: /System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness

If you both want can try my script, although I think @pookjw implemented it so don't know if it will work neither: https://github.com/aonez/NightShiftPatcher

pookjw commented 6 years ago

Sorry for inconvenience. I'm installing 10.13.4 to my MacBook now so will be late for update.

NightPatch backup is located on /Library/NightPatch

so if you want to revert, boot into Recovery mode and open Terminal. Run these commands. (Note: If you are using APFS, use High Sierra Recovey mode.)

cd "/Volumes/${NAME}"

${NAME} means your macOS partition like Macintosh HD.

cp Library/NightPatch/CoreBrightness.bak System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness

cp -r Library/NightPatch/_CodeSignature.bak System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/_CodeSignature

Reboot your Mac.

Again, sorry for inconvenience and I will update after 10.13.4 installation.

pookjw commented 6 years ago

Image

Hmm, it works well on my MacBook6,1 without any modifications (NightPatch Version 246 - latest stable). I clean installed this.

mandril420 commented 6 years ago

@pookjw @aonez Thank you so much for the quick reply everyone. I booted into recovery and restored the backup CoreBrightness files and then my Mac booted normally again. After that I reinstalled Nightpatch 246 and its working well. I don't know what happened before :/ Anyway thank you guys!

slw287r commented 6 years ago

I've just Recovery mode-ed my MBP 2010. I'd like to have a go of your latest stable version 246.

It's wired that my Mac Pro (2013 trash can design) with 10.13.4 has night shift built-in but it's not working. Any ideas?

IgorFromRussia commented 6 years ago

I just wanted to let you know that this patch results in unbootable machine on the first beta of 10.13.5 as well (MacBook Pro Late 2011 17’). Hope some fix will appear in the future. Thank you for your work.

pookjw commented 6 years ago

Imgae

Hmmmmmmmmmm

pookjw commented 6 years ago

I need more information to fix unbootable issue because my MacBook6,1 causes no issue. I need NightPatch log (can record by running --verbose option) and macOS verbose boot log and specific symptom.

IgorFromRussia commented 6 years ago

I think I have found the solution. It is strange but it works. What you have to do is to patch using terminal as usual, then revert and patch again. It all has to be done one after another (without rebooting). After that you can successfully reboot and Night Shift option will appear. I don’t know what originally caused this issue but this is a workaround of it. Hope it helps others with similar problem as well.

mandril420 commented 6 years ago

So now I updated my MacBookAir 2011 to 10.13.4 and after installing NightPatch 246 it would not boot anymore. So I went into recovery and restored the core brightness files and the computer was bootable again. After that I again reinstalled NightPatch 246 but this time is working fine. I had to go through the same process on my Mac Pro. So I think that IgorFromRussia is onto something here. Seems that you need to install twice for it to work for some reason.

kis87988 commented 6 years ago

Fail the first time without --verbose and then did

cd "/Volumes/${NAME}"

${NAME} means your macOS partition like Macintosh HD.

cp Library/NightPatch/CoreBrightness.bak System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness

cp -r Library/NightPatch/_CodeSignature.bak System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/_CodeSignature

Did above then back to OS Patch with --verboose under below

************************************************************************************************************************************************************************
TOOL_VERSION=246
TOOL_BUILD=stable
SYSTEM_BUILD=17E199
SYSTEM_VERSION=10.13.4
MACHINE_MODEL=MacBookPro8,1
PATCH_COUNT=7
TOOL_MODE=patch
VERBOSE=YES
SKIP_CHECK_SYSTEM=NO
SKIP_CHECK_HW=NO
USE_LOCAL_CACHE=NO
PWD=/private/tmp/NightPatch-master
************************************************************************************************************************************************************************
Detected backup, reverting...
/System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness: replacing existing signature
Creating backup...
Patching...
FIRST_SHA=811aa72bce28335efc04b760f849c98e3ff52c2a
CB_OFFSET=0x35000
28+0 records in
28+0 records out
28 bytes transferred in 0.000180 secs (155550 bytes/sec)
SECOND_SHA=2e1cf038db47f6c92f011ccca21290878627cfc4
/System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness: replacing existing signature
Done. Reboot your macOS.
Exit code: 0

Then revert and patch again with verbose under below

************************************************************************************************************************************************************************
TOOL_VERSION=246
TOOL_BUILD=stable
SYSTEM_BUILD=17E199
SYSTEM_VERSION=10.13.4
MACHINE_MODEL=MacBookPro8,1
PATCH_COUNT=7
TOOL_MODE=patch
VERBOSE=YES
SKIP_CHECK_SYSTEM=NO
SKIP_CHECK_HW=NO
USE_LOCAL_CACHE=NO
PWD=/tmp/Night
************************************************************************************************************************************************************************
Detected backup, reverting...
/System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness: replacing existing signature
Creating backup...
Patching...
FIRST_SHA=811aa72bce28335efc04b760f849c98e3ff52c2a
CB_OFFSET=0x35000
28+0 records in
28+0 records out
28 bytes transferred in 0.000160 secs (175023 bytes/sec)
SECOND_SHA=2e1cf038db47f6c92f011ccca21290878627cfc4
/System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness: replacing existing signature
Done. Reboot your macOS.
Exit code: 0

Now it works. Hope this help. If you need to first time fail verbose data. Please let me know. I can restore from TM and fail it again. 😃

guillemap commented 6 years ago

Thank you so much! It worked for me too (Macbook Pro 7.1) To sum up all the process:

  1. (Disable SIP)
  2. Patch normally
  3. Reboot. If it doesn't reboot:
    1. Boot into recovery and apply @kis87988 commands (cp Library/[...])
    2. Reboot
    3. Patch normally again
    4. Revert normally with backup method
    5. Patch normally again
    6. Reboot and it works!
  4. (Enable SIP)

Note: when applying/reversing the patch I used the --verbose flag

software-network commented 6 years ago

Does this work in High Sierra 10.13.4 (17E199) on a MacBook Pro (mid 2010)?

jnetshaw commented 6 years ago

Not for me. Have the same Mac. Tried the 'solutions' above. Had to reinstall OSX finally.

software-network commented 6 years ago

I booted into Safe Mode and reverted the changes using the Uninstaller.sh command. The commands failed to work. You need to update this dev. Absolute headache.

pookjw commented 6 years ago

@appleretail NightPatch doesn't have Uninstaller.sh. It seems like you used TMRJIJ/Night-Shift-on-Unsupported-Macs. That's not my script.

software-network commented 6 years ago

@pookjw Oh really? Ah. Is your script the same, as the other one caused the computer to get stuck on boot, is yours any different?

pookjw commented 6 years ago

@appleretail TMRJIJ/Night-Shift-on-Unsupported-Macs patches your Mac with 'copying already patched system file'. But that system file is old, not 10.13.4 system file. So it will cause problem on the latest macOS. NightPatch patches your Mac instantly, not copying already patched system file. (Thanks to @aonez)

I know many people undergo unbootable issue but NightPatch works well on my Mac (MacBook6,1 10.13.4, 10.13.5). I am looking into this problem but I am busy these days... playing Overwatch game 10hrs everyday. It is really fun, sorry. Anyway, I will fix this issue.

software-network commented 6 years ago

@pookjw OK, thanks for your response :) and when you fix this issue, say there is another incompatibility in say 10.13.6, will updating to that undergo an issue like that again?

pookjw commented 6 years ago

@appleretail I don't know because that is future :P. But maybe will works. maybe...

software-network commented 6 years ago

@pookjw Oh, OK. Thanks again! I like devs who interact with their community. Look forward to the update!! :D

aonez commented 6 years ago

playing Overwatch game 10hrs everyday

@pookjw I'm sure you don't play on your NightPatched MacBook 😂

tchek commented 6 years ago

Hey !

Same Issue here : on 10.13.4 / 17E202, no boot after install. Recovery mode and reinstalling 10.13.4 brought me back to normal, because none of the solutions mentioned above worked for me. Sorry but no log ! Only : iMac10,1 Hope for an update :-)

Cheers !

mandril420 commented 6 years ago

@tchek The way that I got Nightpatch 246 to work is after it fails and you can't boot into your Mac. You boot into recovery mode and restore the files as pookjw posted above and then boot normally and reinstall night patch 246 again right after. This time it your Mac will boot normally and night patch will work just fine.

software-network commented 6 years ago

@mandril420 but then definitely a possibility that it could break again after Updating to macOS 10.13.5 releasing soon. Best to wait for an official fix.

tchek commented 6 years ago

@mandril420 Thank you for help, but it definitely does not work here ! As ©appleretail said, i'll wait for a reliable update ;-)

michaelevancoe commented 6 years ago

kis87988's solution worked for me. 2009 Mac Pro updated to 5.1 (nvidia graphics driver GTX 1080ti Dell 4k monitors)

THANKYOU!

Romko23 commented 6 years ago

Hmm.. I have 5,1 Mac Pro and this thing bricked my system. I will just wait until the nightshift patch works for 10.13.5. What a waste of time and productivity as I had to use SIERRA to reinstall High Sierra.

michaelevancoe commented 6 years ago

@romko23 Did this happen while having nightpatch installed on 10.13.4 and then updating to 10.13.5 bricked it? Haven’t updated yet and have nightpatch on 10.13.4

Romko23 commented 6 years ago

Updating 10.13.5 - I am afraid to run this script again.. because it took me over an hour to restore HS back to my Mac pro - thank God for Sierra on a USB thumb drive :)

Romko23 commented 6 years ago

I also wamt to add that i tried it with 10.13.4 and it also didn't work.. but it didn't brick my machine.. When I installed 10.13.5 and then i tried it again, I was not able to restore HS on the Mac Pro as it asked for to re-run the firmware update - sadly, that didn't work.. so i said F it and I decided to just use Sierra to re-install HS.

michaelevancoe commented 6 years ago

Got it thank you. I’ll post back here on how my update to 10.13.5 (with firmware update from USB) goes with nightpatch installed on 10.13.4.

Romko23 commented 6 years ago

michaelevancoe Please do and let me know what i need to do to get it working.

m-emelchenkov commented 6 years ago

On 10.13.5 works well, thanks to author!

$ cat /Library/NightPatch/NightPatchBuild 17F77

The procedure:

  1. Disable CSR protection from Recovery.
  2. Boot into the system and apply the patch.
  3. Reboot the system and make sure it works OK.
  4. Enable CSR protection from Recovery.
tchek commented 6 years ago

Not work here on 10.13.5/ 17F77

JimmyPastel commented 6 years ago

Hi everyone, tried on 10.13.5 and I can’t boot, I don’t used terminal, so I’m trying to follow the steps for revert the path and can boot and I’m not able, please if someone can help me explaining like a new user... My volume is Macintosh, and I tried the commands separate all together and no way, some help please.

3b84707d-1447-464b-ac2b-6476a78ac310

aonez commented 6 years ago

@JimmyPastel You're doing something wrong. Press control + C so the > symbol disappears. Then start with the commands again. If > appears at the start of the line, you're writing something wrong.

Take a look for example at cd \"Volumes/Machintosh\" cp .... Those are two different sentences. So execute them separately or use a ; between them. i.e. cd \"Volumes/Machintosh\"; cp...

JimmyPastel commented 6 years ago

@aonez thank you! finally got it, thanks so much for your help,

Romko23 commented 6 years ago

I gave up... will wait for a patch.. DAMN U APPLE !

rokka8 commented 6 years ago

works for me fine on High Sierra 10.13.6! Apple MacBook Pro Late 2011. 👍

uandco commented 6 years ago

That did work on 10.13.6 for me too, but only after failing / reverting in recovery mode, then patching again, reverting using the backup method, and patching a third time without rebooting as described by @guillemavila

Squuiid commented 6 years ago

Folks, try this one instead. Works in Mojave also. https://github.com/aonez/NightShiftPatcher