poole / lanyon

A content-first, sliding sidebar theme for Jekyll.
http://lanyon.getpoole.com
Other
3.25k stars 2.95k forks source link

Navbar open/close moves the page to the top #192

Closed rom1v closed 4 years ago

rom1v commented 7 years ago

Since commit f039ccba3347ff8cebb6baea08efa01da497d6a3 (found through git bisect), opening/closing the navbar moves the page to the top, which is very annoying.

Reverting a part of the patch avoids the problem:

diff --git a/public/css/lanyon.css b/public/css/lanyon.css
index bc1408f..50bd789 100644
--- a/public/css/lanyon.css
+++ b/public/css/lanyon.css
@@ -202,6 +202,7 @@ a.sidebar-nav-item:focus {

 /* Hide the sidebar checkbox that we toggle with `.sidebar-toggle` */
 .sidebar-checkbox {
+  display: none;
   position: absolute;
   opacity: 0;
   -webkit-user-select: none;

cc @mdo

mdo commented 4 years ago

Duplicate of #137.