poole / lanyon

A content-first, sliding sidebar theme for Jekyll.
http://lanyon.getpoole.com
Other
3.25k stars 2.95k forks source link

Jumping sidebar on safari #4

Closed boulox closed 10 years ago

boulox commented 10 years ago

Browser: safari 7.0.1 OSX 10.9.1

Safari audience is not that big, but just keep record of it

Does not happen in chrome. Didn't have a chance to look on an iPad

mdo commented 10 years ago

Interesting. It looks smooth enough on 10.9 with Safari 7.0. Wonder what changed. Upgrading now and will take a peak. (Also note this isn't officially out yet, so shit might be changed/busted/etc—thanks for reporting though!)

boulox commented 10 years ago

I get that this is a wip, i am just super interesting about that drawer with no JS. :)

Look like your commit https://github.com/poole/lanyon/commit/cbbb23e8705a4a07d1e4a8a4b781476ca8948fa6 fixe the 2nd issues

Sidebar still in open state when you open/reload the page and then close, this happen only when browser windows 768px and up.

mdo commented 10 years ago

Should be good to go in Safari. I had to revert to the position method though because transforms fuck up the position: fixed on the toggle in the top left. I could fix with JS, but that sucks. The bug with the positioning is known, but I don't think Chromium of Webkit would change it :. Even if they did now, it wouldn't make a difference here.