pooler / electrum-ltc

Electrum-LTC Litecoin wallet
https://electrum-ltc.org
MIT License
194 stars 100 forks source link

Provide release tarballs with git submodules included. #301

Closed amano-kenji closed 1 year ago

amano-kenji commented 1 year ago

github doesn't generate tarballs with git submodules. Repository maintainers have to manually add tarballs with git usbmodules to releases.

pooler commented 1 year ago

Are you using the 4.2.2.1 tarball from electrum-ltc.org?

amano-kenji commented 1 year ago

https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz is already built.

On gentoo linux, almost everything is built from source.

pooler commented 1 year ago

https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz is already built.

I'm honestly not sure what you mean. That's the Python source code.

amano-kenji commented 1 year ago

https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz looks different from https://github.com/pooler/electrum-ltc

Can a linux distribution package build script build and install electrum-ltc from https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz ?

pooler commented 1 year ago

https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz looks different from https://github.com/pooler/electrum-ltc

They are different. One is the distribution tarball for version 4.2.2.1, the other is the current master branch of the Git repository.

Can a linux distribution package build script build and install electrum-ltc from https://electrum-ltc.org/download/Electrum-LTC-4.2.2.1.tar.gz ?

I don't see why not.

amano-kenji commented 1 year ago

If there is a problem, I'll open a new issue.