search

poonchuanan / pe

0 stars 0 forks source link

Does not account for variant modules for exam #1

Open poonchuanan opened 3 years ago

poonchuanan commented 3 years ago

GER1000H was not accepted.

image.png

nus-pe-bot commented 3 years ago

Team's Response

The datatbase of NUS modules we used is from 2018 to 2019 and GEH1000H is not provided by NUS at that time. please refer to this website for verification. Perhaps, we could have mentioned it in the UG that the database is in fact from 2018 to 2019. The resaon why we did not use the most update version is because we encountered some error and was not able to generate the most updated list from the NUSMod API website. Nonetheless, we still believe the module checker function served its purpose and should not be considered as a functionality bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This issue is definitely in the scope of the project as the module checker is supposed to check for the validity of any NUS modules entered by the user. Thereafter, it will allow the user to add exam dates based on whether the checks was passed or not. However, it does not fulfil the requirements of being a reliable one as many of NUS mods that are not from 2018-2019 will be flagged as invalid.

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: This was flagged as a functionality bug as the module checker rejects valid NUS modules as correct inputs, causing inconvenience to the users.

As mentioned by the team, data from 2018-2019 was used, but that should not be the case as what is the point of refering to an outdated timetable? No students would want to use the application should that be the case. They would not be able to benefit fully from the application because they would not be allowed to add some of the modules they are taking.

The application only considers data from one short year of 2018-2019 which affects the full functionality of the function to check for valid module codes.

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: I believe that this is a high severity issue as this actually affects a large number of their target audience. As seen from the user guide, the application is targeted at all NUS students. image.png This includes students from all disciplines, undergraduate and graduate programmes.

Here are some of the modules from various faculties that I've tried and did not work: -BSP1703X(Business) -AA1201(FASS) -MD1140(Medicine) -PRV2110(Dentistry) -EG2310(IDP) -GET1050(GE module) image.png

Just for example, GET1050 is a complusory module for all undergraduate students from FASS. Not being able to add the module greatly hinders the application usability, which was why this issue was tagged as high in the first place.