poooi / plugin-quest

show quest info
MIT License
4 stars 7 forks source link

Incorrect i18n parsing on modal conversion quests. #44

Closed gnattu closed 6 years ago

gnattu commented 6 years ago

https://github.com/poooi/plugin-quest/blob/bbe64b4fc82bf8eea7c1beb69263b0d3268a3c9a/assets/i18n/zh-CN.json#L179 In the case that maxed modification is required, but fully skilled is not , such structure will make the max-modification requirement take the position of the skill requirement, which resulted in an incorrect display. For example:

screen shot 2018-01-19 at 14 26 27

Edit: The display is still incorrect even after adding "fullyskilled": false, to data.json manually. https://github.com/poooi/plugin-quest/blob/bbe64b4fc82bf8eea7c1beb69263b0d3268a3c9a/assets/data.json#L10442-L10448 use_skilled_crew should not be defined inside the slots by the way, it should be directly inside the requirements to be displayed.