Use codacy for code reviews and monitors code quality

[AlanJager]

How about using this site to automate code reviews and monitors code quality over time

[KagamiChan]

I'll be glad to see frequent PRs that push us to deploy a such system :)

[AlanJager]

Thanks for your reply. Actually, I just think code review will help to improve the quality of code.

[KagamiChan]

To explain to everyone interested: We do have code review for every PR, although some communications take place within IM, not on github. And we have eslint as linter which could prevent many mistakes For now, poi has only a few tests and limited code coverage. It is not something to show off, but writing tests will take more effort than implementation. If we recieve more frequent PRs or have more active devs, we could make up the tests.

Anyway, bug reports, suggestions, ideas, PRs, and devs are always welcome :)

[AlanJager]

I know spectron could be a good way for testing electron app. But I still need sometime to find a good solution for the test part of poi. So....

[AlanJager]

There are some issues came up by this site where I add a forked poi. I'm not really understand are these issues making any sense, but they just throw bad issues.

[yukixz]

wow auto-test for poi.

[AlanJager]

@yukixz it's just the result came out with cadacy's code review, but when come to auto-test, maybe it is another concept.

[KochiyaOcean]

Hmm, one of the problems is, some codes' stability is depends on Takana and is hard to generate a test case :-(

[AlanJager]

Oops, maybe we need more time to consider solutions for this problem.

[KagamiChan]

As we have introduced eslint into ci, code will be linted per pull request