pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS
https://pop-shop-github.vercel.app/
MIT License
29 stars 68 forks source link

Fix Navbar at top and close Dropdown on choosing an option #166

Closed Utsavladia closed 1 month ago

Utsavladia commented 1 month ago

Description

The Navbar should be fixed at top so it will be usefull from anywhere in the website. Also the dropdown menu should be closed automaticaly on choosing any option from it.

image

I would love to contribute to this and make the user experience better.

Screenshots

No response

Checklist

pooranjoyb commented 1 month ago

Congratulations, @Utsavladia! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

pooranjoyb commented 1 month ago

I don't think fixed Navbar is necessary as of now. @AjayAsnani Please do lmk if the second part of closing NavDropdown on click is necessary.

Utsavladia commented 1 month ago

Dear @pooranjoyb should I fix the second part then ??

AjayAsnani commented 1 month ago

I don't think fixed Navbar is necessary as of now. @AjayAsnani Please do lmk if the second part of closing NavDropdown on click is necessary.

Can be implemented as it's a good practice of selecting any option closes the NavDropdown

pooranjoyb commented 1 month ago

Ok go ahead 🚀 @Utsavladia