pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS
https://pop-shop-github.vercel.app/
MIT License
29 stars 68 forks source link

[Feature] User should be allow to browse without login #169

Closed Utsavladia closed 3 weeks ago

Utsavladia commented 1 month ago

Description

The user should be able to browse without login and while ordering it will ask for login that will enhance the user experience.

Screenshots

No response

Checklist

pooranjoyb commented 1 month ago

Congratulations, @Utsavladia! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

pooranjoyb commented 1 month ago

What say @Mahitej28 @AjayAsnani ? Do lmk your thoughts.

Mahitej28 commented 1 month ago

What say @Mahitej28 @AjayAsnani ? Do lmk your thoughts.

Well yes its a good idea, this way the user gets an idea about the stuff present on website it would improve user experience, looks good to me!

AjayAsnani commented 1 month ago

Yes this has to be implemented because if user have to login first before exploring the website can reduce traffic.

Utsavladia commented 1 month ago

So should I start working on it ??.. Also let me know if you have any special requirements or suggestion.

AjayAsnani commented 1 month ago

So should I start working on it ??.. Also let me know if you have any special requirements or suggestion.

What else you can add except this like you asked special requirements or suggestion.

Or share your workflow how you will implement and when it will ask for login if user is browsing without login.

Utsavladia commented 1 month ago

@AjayAsnani
Asking for login when the user want to order. Add to cart will store in local storage without login and transfer all after login but this can be implimented once the add to cart feature will be added.

pooranjoyb commented 1 month ago

Have a look on ProtectedRoutes.tsx possibly you'll need to change a lot there. @Utsavladia

Mahitej28 commented 1 month ago

@Utsavladia update us by EOD

Utsavladia commented 3 weeks ago

@pooranjoyb Sir, I kept resolving the conflicts again and again but due to delay in merging the branch new conflicts used to come and now also I could have resolved it I dont know how this notification got missed. sir I have spent time on this issue I request you to kindly let me fix and make it a successfull merge.

pooranjoyb commented 3 weeks ago

Mentors will check and reopen accordingly. @Utsavladia Check #195