[Feature] Refactor `Terms&Conditions` UI

pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS

https://pop-shop-github.vercel.app/

MIT License

34 stars 71 forks source link

[Feature] Refactor `Terms&Conditions` UI #188

Closed masterboy376 closed 3 months ago

masterboy376 commented 4 months ago

Description

Use the Head component for the titles. Update all the headings in this page.
There should be only these titles. (Terms and Conditions, Cookies, License). Rest remove all.
Now beautify these three. Use lists and underline and images if needed.
Maintain the theme and colors of the website if you're using any.
Remove unnecessary links like home/terms-and-conditions#terms and update the Footer.tsx accordingly.
There should be only one link i.e Terms and Conditions in the Footer. That'll do.
Make sure it is mobile responsive.

Do ask @Mahitej28 or @AjayAsnani for nay doubts. They'll help you. @yashi-15

pooranjoyb commented 4 months ago

Congratulations, @masterboy376! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

masterboy376 commented 4 months ago

Hello @pooranjoyb, I would like to work on this issue under GSSOC'24. I have past experiences of implementing such features. PTAL

pooranjoyb commented 4 months ago

One issue at a time @masterboy376

yashi-15 commented 4 months ago

Hey @pooranjoyb, I can work on this issue.. Kindly assign it to me under GSSOC'24.

pooranjoyb commented 4 months ago

Hii @yashi-15 seen your work in the last PR. Just wanted to modify this issue for the refactoring of Terms and Conditions UI. Would you like to work on that?

yashi-15 commented 4 months ago

Hii @yashi-15 seen your work in the last PR. Just wanted to modify this issue for the refactoring of Terms and Conditions UI. Would you like to work on that?

Sure, I can do that... @pooranjoyb

pooranjoyb commented 4 months ago

Okay I am changing the issue title and description. Please do the changes accordingly. @yashi-15

AjayAsnani commented 4 months ago

Double-check the responsiveness on every breakpoint. @yashi-15

Mahitej28 commented 4 months ago

Hey @yashi-15 give your updates by eod, also do let me or @AjayAsnani know incase of any doubts.

yashi-15 commented 4 months ago

Hey @Mahitej28 @AjayAsnani , I have done some changes till now,

Changes done:

Removed headings other than Terms and Conditions, Cookies, License.
Added images for each head.
Added list, bold, justify text properties to the text content and head styling to headings.

Changes yet to be made:

Check responsiveness
Changes in footer and link.

I want to confirm from your side if the images are looking good or not (especially Cookies one, for which I am doubtful). Should I remove all the images or change any. Please give me your suggestions...

Screenshot (576) Screenshot (577) Screenshot (578)

pooranjoyb commented 4 months ago

Looks good to me! @Mahitej28 Please have a look and suggest the changes if necessary.

AjayAsnani commented 4 months ago

Ohk images are looking fine.

pooranjoyb commented 4 months ago

We can go ahead for a PR then @yashi-15 @AjayAsnani or @Mahitej28 will review and merge it.

AjayAsnani commented 4 months ago

Yes first complete all the mentioned issues and make a PR @yashi-15

yashi-15 commented 4 months ago

Sure! @pooranjoyb @AjayAsnani