dhruv8433 commented 1 month ago

@pooranjoyb

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Add product to cart as well as on Supabase [One to Many relationship] #109 Fixes # 109

Type of change

Please give a X on it which is applicable

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

How Has This Been Tested?

when user add any item to cart it also display in supabase cart table

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshorts and Vedios:

Checklist:

give a X on it which is applicable

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pop-shop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 9, 2024 2:15pm

dhruv8433 commented 1 month ago

@pooranjoyb

please check this and merge it

pooranjoyb commented 1 month ago

Hii @dhruv8433 why aren't you using the Cart-Slice we need to store that in store too. Maintain that too.

dhruv8433 commented 1 month ago

@pooranjoyb

now you can check it and merge it : i update code and now it also added to cart-slice too

dhruv8433 commented 1 month ago

@pooranjoyb please tell me if you want any kind of modifications...

pooranjoyb commented 1 month ago

@pooranjoyb please tell me if you want any kind of modifications...

Can you show me a video demonstration @dhruv8433

It's not working on my end :/

dhruv8433 commented 1 month ago

Ok i will share you video

dhruv8433 commented 1 month ago

@pooranjoyb

yaa, i understood.. bymistek i added username as primary key

now you can check it working properly

https://github.com/pooranjoyb/popShop/assets/114583978/af15c37e-6dbe-485f-8e98-7a1e7ba6ad2b

dhruv8433 commented 1 month ago

@pooranjoyb

please check this and merge it if you face any issue then inform me

pooranjoyb commented 1 month ago

@pooranjoyb

please check this and merge it if you face any issue then inform me

@pooranjoyb

please check this and merge it if you face any issue then inform me

@pooranjoyb

please check this and merge it if you face any issue then inform me

Dude, why Buy Now adds to cart. The flow is different. User should go to the Product-Details page and Add to Cart button should do that logic. Please update it. @dhruv8433

dhruv8433 commented 1 month ago

@pooranjoyb Ok ok Got it

dhruv8433 commented 1 month ago

@pooranjoyb

now you can check it

pooranjoyb commented 1 month ago

check build errors by running npm run build in you local machine.

dhruv8433 commented 1 month ago

@pooranjoyb

solved completed build

dhruv8433 commented 1 month ago

@pooranjoyb

Please merge it

dhruv8433 commented 1 month ago

@pooranjoyb

now you can check this i completed my task as you said

please check this and merge it

dhruv8433 commented 1 month ago

@pooranjoyb

deployment and build both are completed please merge it

dhruv8433 commented 1 month ago

@pooranjoyb

Please when you become free Merge it

pooranjoyb commented 1 month ago

@pooranjoyb

Please when you become free Merge it

Hii @dhruv8433 really sorry, I was occupied few days. Okay I've seen the deployment. Everything is working fine but just one improvement.

There are static images in the cart.
Make sure that, when Product is added to Cart it is should in the Cart page.
Use the slice or supabase-table to render the items added to cart.
Also I can see multiple rows are created for a single user when multiple items are added to cart. Update that make sure you just update that json with the new cart item and push to supabase

Should be one entry having array of items in cart.

That'll do. I'll merge once this part is done. 🚀

dhruv8433 commented 1 month ago

@pooranjoyb

i need help when i try to add product for same user it give me cors error can you please tell me how to resolve this

can you allow cors from supabase ?

pooranjoyb commented 1 month ago

@pooranjoyb

i need help when i try to add product for same user it give me cors error can you please tell me how to resolve this

can you allow cors from supabase ?

please check in supabase. RLS is already disabled. I guess you already have an access. @dhruv8433

dhruv8433 commented 1 month ago

@pooranjoyb

i tried many times but i can't find allow origin cors in supabase dashboard can you please help...

dhruv8433 commented 1 month ago

@pooranjoyb

now everything working as expected please check this and merge it

output:

dhruv8433 commented 1 month ago

@pooranjoyb

https://github.com/pooranjoyb/popShop/assets/114583978/7f2a720e-871e-4a1e-9739-5166d3805293

dhruv8433 commented 4 weeks ago

@pooranjoyb

now you can merge it please check everything working as expected

pooranjoyb commented 4 weeks ago

Awesome work @dhruv8433 🚀 What was the issue with cors tho ?

dhruv8433 commented 4 weeks ago

@pooranjoyb

no i just redisable RLS and try than it worked

dhruv8433 commented 4 weeks ago

please merge it

pooranjoyb commented 4 weeks ago

please merge it

Dude it ain't working, just checked the deployment. :/

screen-recorder-sun-jun-09-2024-18-59-44.webm

pooranjoyb commented 4 weeks ago

Please lmk if I'm missing something, do create a new record if the user doesnot exist in the table. @dhruv8433

dhruv8433 commented 4 weeks ago

@pooranjoyb

just wait i provide you a video

pooranjoyb commented 4 weeks ago

A hell loota work, init @dhruv8433 ? 😆 But yeah at the end its working. So, well done! 💯

dhruv8433 commented 4 weeks ago

Thank you @pooranjoyb

idk why video not downloaded bu thanks again

pooranjoyb commented 4 weeks ago

Thank you @pooranjoyb

idk why video not downloaded bu thanks again

But yeah there is still one issue. I guess that's probably easy to work around.

The functioning is working properly in a single browser but not in other browsers as you are fetching data from redux store.
while rendering the cart items fetch it from db and show.
Although the admin has two items in cart its not showing up in carts page.

@dhruv8433

you can work on this in a separate issue. 👍🏼

dhruv8433 commented 4 weeks ago

@pooranjoyb Ok i will create separate issue for thay

pooranjoyb / popShop

Cart Management #193

Type of change

How Has This Been Tested?

Screenshorts and Vedios:

Checklist: