Utsavladia commented 1 month ago

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #169

Type of change

Please give a X on it which is applicable

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here Tested by going to all the routes.

Test B Describe here (if Requred)

Screenshorts and Vedios:

give screenshorts and vedio of the changes you made

Checklist:

give a X on it which is applicable

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pop-shop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 17, 2024 3:29pm

pooranjoyb commented 1 month ago

Fix the build errors. Verify with npm run build @Utsavladia

pooranjoyb commented 4 weeks ago

There are conflicts. Fix them. And lmk when are you free tomorrow, there are lot of issues that needs to be covered. @Utsavladia

Utsavladia commented 4 weeks ago

@pooranjoyb I have resolved the conflicts. And I am free till 2pm.

pooranjoyb commented 4 weeks ago

Okay try to fix this now. @Utsavladia

Mahitej28 commented 4 weeks ago

Okay try to fix this now. @Utsavladia

@Utsavladia try to work upon this, also there are merge conflicts take a pull from dev and then start working

Utsavladia commented 4 weeks ago

@Mahitej28 @pooranjoyb Fixed the Nav links in updated floating navbar and undefined section of dropdown.

pooranjoyb commented 4 weeks ago

Bruh, please remove use Conditional rendering for Login and Logout. Obviously how will a user Logout without Login? @Utsavladia

pooranjoyb commented 3 weeks ago

Fix the conflicts. @Utsavladia

Mahitej28 commented 3 weeks ago

@Utsavladia your pr has merge conflicts, resolve that and take a pull from dev before pushing commits.

pooranjoyb commented 3 weeks ago

Hii @Utsavladia please check the build errors. run npm run build in your local machine and debug accordingly. :)

Utsavladia commented 3 weeks ago

@pooranjoyb sure, Resolved the conflicts and debugged the build error.

Mahitej28 commented 3 weeks ago

@Utsavladia I can still see merge conflicts resolve it first, your Navbar.tsx file has 4 merge conflicts resolve that and before that take a pull from dev

Utsavladia commented 3 weeks ago

@Mahitej28 I hope it is fixed now Please let me know if any changes required.

pooranjoyb commented 3 weeks ago

merge conflicts :/ @Utsavladia

pooranjoyb commented 3 weeks ago

Closing as inactive.

Utsavladia commented 3 weeks ago

@pooranjoyb Sir, I kept resolving the conflicts again and again but due to delay in merging the branch new conflicts used to come and now also I could have resolved it I dont know how this notification got missed. sir I have spent time on this issue I request you to kindly let me fix and make it a successfull merge.

pooranjoyb commented 3 weeks ago

Okay @Mahitej28 & @AjayAsnani will check and respond accordingly.

Mahitej28 commented 2 weeks ago

@Utsavladia will give you two days time to complete it.

Utsavladia commented 2 weeks ago

@pooranjoyb @Mahitej28 Resolved the conflicts and synced with the latest branch I hope now it is working perfectly fine..

Utsavladia commented 2 weeks ago

@Mahitej28 Mam this merge did not get counted in my contributions to GSSoC. I think you will also have to assign this pulll request to me so that it gets counted 😊

pooranjoyb commented 2 weeks ago

@Mahitej28 Mam this merge did not get counted in my contributions to GSSoC. I think you will also have to assign this pulll request to me so that it gets counted 😊

Wait for 24 hours, it takes time to update.

pooranjoyb / popShop

fixed to allow uesr to explore without login #195

Type of change

How Has This Been Tested?

Screenshorts and Vedios:

Checklist: