pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS

https://pop-shop-github.vercel.app/

MIT License

29 stars 66 forks source link

Terms and conditions UI refactor. #199

Closed yashi-15 closed 3 weeks ago

yashi-15 commented 4 weeks ago

Refactoring Terms & Conditions UI.

Fixes #188 @pooranjoyb @Mahitej28 @AjayAsnani Kindly review and merge under GSSOC'24.

Type of change

Please give a X on it which is applicable

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

Screenshorts and Vedios:

Screenshot (579) Screenshot (580) Screenshot (581)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pop-shop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 8, 2024 5:43am

Mahitej28 commented 4 weeks ago

@yashi-15 you need to look at the responsiveness of the website its getting distorted.

Also the images are not loading.

yashi-15 commented 4 weeks ago

Hi @Mahitej28, I checked this thing in my browser. There is no issue with the responsiveness or the images. Can you tell me for which specific screen size it's not responsive because in my browser its working good for every screen size...

Screenshot (582) Screenshot (584) Screenshot (585) Screenshot (586) Screenshot (588)

pooranjoyb commented 4 weeks ago

Hii @yashi-15 I can see the issue in Mozila too! Check the deployment.

Mahitej28 commented 4 weeks ago

Hii @yashi-15 I can see the issue in Mozila too! Check the deployment.

Exactly even in chrome too, go through the deployment @yashi-15

yashi-15 commented 4 weeks ago

Hii @yashi-15 I can see the issue in Mozila too! Check the deployment.

Exactly even in chrome too, go through the deployment @yashi-15

@Mahitej28 Yes, I checked now... I was not checking the deployed one earlier. I will solve this issue asap.

yashi-15 commented 3 weeks ago

Hey @pooranjoyb @Mahitej28 @AjayAsnani , I have solved the problem. Please review it and inform me if any further modifications are required.

Mahitej28 commented 3 weeks ago

Looks go to me, will merge it !