pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS

https://pop-shop-github.vercel.app/

MIT License

29 stars 66 forks source link

Feat: update readme file to make it more appealing #212

Closed harini-1597 closed 1 week ago

harini-1597 commented 3 weeks ago

Fixes https://github.com/pooranjoyb/popShop/issues/203

Type of change

Please give a X on it which is applicable

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactor Code
[ ] A documentation update
[ ] Others(mentioned in the issue number)

Screenshots and Videos:

https://github.com/pooranjoyb/popShop/assets/128628820/ed6792dc-e00f-4948-b95e-968e9be47f4c

Checklist:

give a X on it which is applicable

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
pop-shop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2024 5:09am

pooranjoyb commented 3 weeks ago

Hii @harini-1597 can you also update the macbook image for the website?

harini-1597 commented 3 weeks ago

What exactly do you want to update about the macbook image?

pooranjoyb commented 3 weeks ago

What exactly do you want to update about the macbook image?

I actually meant that, the landing page shown in the macbook is outdated. please update it. @harini-1597

Mahitej28 commented 3 weeks ago

What exactly do you want to update about the macbook image?

I actually meant that, the landing page shown in the macbook is outdated. please update it. @harini-1597

@harini-1597 he means that you should be more creative, the idea of the landing page on MacBook is old and doesn't look attractive, you can have a look at this https://github.com/shabrina12/FullStack-Ecommerce-Clothing-Web/blob/main/README.md just try something more creative, and ig images without macbook or anything will be more better

harini-1597 commented 3 weeks ago

@pooranjoyb i updated the image to the current homepage

pooranjoyb commented 3 weeks ago

@pooranjoyb i updated the image to the current homepage

It's not showing up please check again.

harini-1597 commented 3 weeks ago

is it working now? if not, just merge the branch and update the image link from your main github branch. the readme png is available in popShop/public/images/readme.png

Mahitej28 commented 3 weeks ago

@harini-1597 why are their two same images in the Readme.md also I cant see any creativity plus why are there merge conflicts in your pr? just resolve all the issues by eod or else I will close the issue

pooranjoyb commented 3 weeks ago

Fix conflicts and update by EOD else closing this. :/ @harini-1597

pooranjoyb commented 2 weeks ago

Hey @harini-1597 I am sorry but this is not upto the mark. You should've changed the image in the MacBook, but you removed the entire MacBook. :/

harini-1597 commented 2 weeks ago

Screenshot_20240615_110855_Chrome

pooranjoyb commented 2 weeks ago

Mentors will get back to you dw @harini-1597 👀

pooranjoyb commented 2 weeks ago

Please use the macbook image its not visible.