search

pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS
https://pop-shop-github.vercel.app/
MIT License
33 stars 72 forks source link

Updating Twitter Logo #22

Closed syrnxalno closed 4 months ago

pooranjoyb commented 4 months ago

Go for it! In fact can you do one thing? Replace all the SVGs in Footer with react-icons :))) @syrnxalno

syrnxalno commented 4 months ago

Sure @pooranjoyb, I'll give it a go.

syrnxalno commented 4 months ago

Hello admin @pooranjoyb , I'm finding it a little bit difficult to convert all of the SVGs in the footer into react-icons so is it alright if I just modify the twitter logo as per my initial suggestion? Thank you for considering.

pooranjoyb commented 4 months ago

Convert nahi karna hai, just remove the SVGs and uske jagah pe add the react-icons ka icons, check the official docs like how to use them. If you face any issues, you can DM @Mahitej28 or me in discord. @syrnxalno

sachin0986 commented 4 months ago

Hi @pooranjoyb if you want, you can assign it to me, I have relevant skills to solve this.

pooranjoyb commented 4 months ago

Hi @pooranjoyb if you want, you can assign it to me, I have relevant skills to solve this.

Wait till EOD @sachin0986 , you will be assigned if no PR is raised by then. Let's keep the collaboration & contribution as priority and not as a competition! Hehehe :)

Mahitej28 commented 4 months ago

@syrnxalno let me know if u need any help

Mahitej28 commented 4 months ago

@sachin0986 the issue is now being assigned to you, you can work on it. Make a pr to dev, also make sure to add react-ions in place of svg.