Closed dhruv8433 closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
pop-shop | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 15, 2024 10:49am |
please inform me if you want any modifications
Replace the Close
button with Continue Shopping
with the my-green
button. This button should redirect user to /home/shop
@dhruv8433
Also i can see that you are calling the method to update cart quantity and price on each quantity update. This should not be done as this leads to recurrent requests to the db. Optimize this to make sure that you make only 1 api call to update the quantity and price when user clicks on Place Order
.
Remove this quantity from here too. lets not keep it here. Doesn't make sense to allow user to update quantity everywhere.
@pooranjoyb
Did you do this? @dhruv8433
Also i can see that you are calling the method to update cart quantity and price on each quantity update. This should not be done as this leads to recurrent requests to the db. Optimize this to make sure that you make only 1 api call to update the quantity and price when user clicks on Place Order.
@pooranjoyb
i just removed quantity buttons from detailed product now it's only in cart
Update this API request wala thing. Read the tasks.
ok got it
@pooranjoyb
now you can check this,
redux store
after checkout or place order
@pooranjoyb
please check this and merge it
There are still some bugs, please cross check the deployment. These are the issues that i've found :
I suggest you to revert the changes. this api call wala, keep this aside for a moment.
@pooranjoyb
i revert the changes
@pooranjoyb
please check this and inform me if you need any modifications
Cool! awesome work @dhruv8433 🚀
…fter
checkout
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
@pooranjoyb
[Feature] Make Payment option functionals #233
Fixes #233 (issue)
Type of change
Please give a X on it which is applicable
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test A Describe here
Test B Describe here (if Requred)
Screenshorts and Vedios:
https://github.com/pooranjoyb/popShop/assets/114583978/f0585ac3-9245-422c-84ec-4d5a3fdea808
give screenshorts and vedio of the changes you made
Checklist:
give a X on it which is applicable