pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS
https://pop-shop-github.vercel.app/
MIT License
29 stars 66 forks source link

added `orders` while user checkout their cart and remove cart items a… #239

Closed dhruv8433 closed 2 weeks ago

dhruv8433 commented 2 weeks ago

…fter checkout

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

@pooranjoyb

[Feature] Make Payment option functionals #233

Fixes #233 (issue)

Type of change

Please give a X on it which is applicable

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshorts and Vedios:

https://github.com/pooranjoyb/popShop/assets/114583978/f0585ac3-9245-422c-84ec-4d5a3fdea808

give screenshorts and vedio of the changes you made

Checklist:

give a X on it which is applicable

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2024 10:49am
dhruv8433 commented 2 weeks ago

please inform me if you want any modifications

pooranjoyb commented 2 weeks ago

Replace the Close button with Continue Shopping with the my-green button. This button should redirect user to /home/shop @dhruv8433

Also i can see that you are calling the method to update cart quantity and price on each quantity update. This should not be done as this leads to recurrent requests to the db. Optimize this to make sure that you make only 1 api call to update the quantity and price when user clicks on Place Order.

Remove this quantity from here too. lets not keep it here. Doesn't make sense to allow user to update quantity everywhere. image

dhruv8433 commented 2 weeks ago

@pooranjoyb

  1. bg-my green

image

  1. remove quantity from product detailed

image

pooranjoyb commented 2 weeks ago

Did you do this? @dhruv8433

Also i can see that you are calling the method to update cart quantity and price on each quantity update. This should not be done as this leads to recurrent requests to the db. Optimize this to make sure that you make only 1 api call to update the quantity and price when user clicks on Place Order.

dhruv8433 commented 2 weeks ago

@pooranjoyb

i just removed quantity buttons from detailed product now it's only in cart

image

pooranjoyb commented 2 weeks ago

Update this API request wala thing. Read the tasks.

dhruv8433 commented 2 weeks ago

ok got it

dhruv8433 commented 2 weeks ago

@pooranjoyb

now you can check this,

image

after checkout or place order

image

dhruv8433 commented 2 weeks ago

@pooranjoyb

please check this and merge it

pooranjoyb commented 2 weeks ago

There are still some bugs, please cross check the deployment. These are the issues that i've found :

I suggest you to revert the changes. this api call wala, keep this aside for a moment.

dhruv8433 commented 2 weeks ago

@pooranjoyb

i revert the changes

dhruv8433 commented 2 weeks ago

@pooranjoyb

please check this and inform me if you need any modifications

pooranjoyb commented 2 weeks ago

Cool! awesome work @dhruv8433 🚀