search

pooranjoyb / popShop

eCommerce Shoping Platform (with Admin Panel) based on ReactTS & Daisy UI, integrating Supabase as BaaS
https://pop-shop-github.vercel.app/
MIT License
34 stars 71 forks source link

Resolved Update-Profile-Details #285

Closed bhuvangoel04 closed 3 months ago

bhuvangoel04 commented 3 months ago

Resolved the issue that gender was not getting updated on edit profile. Added the feature to edit gender.

Fixes #281

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pop-shop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 5:01am
pooranjoyb commented 3 months ago

Hii @bhuvangoel04 I can see that you're not restricting the Gender to Male & Female only. Even if I try to save Hii Hello (or any other string) it gets saved.

You can try using a dropdown option to choose (Male or Female) that'll restrict the user to add strings in gender.

bhuvangoel04 commented 3 months ago

Ok I will make changes to it.

bhuvangoel04 commented 3 months ago

Should I close this pull request then and make another one?

pooranjoyb commented 3 months ago

Should I close this pull request then and make another one?

No need, same branch me push karoge toh idhar hi add ho jayega. I mean it's upto you. Just drop a PR by EOD.

bhuvangoel04 commented 3 months ago

I have committed the required changes, please check it out.

pooranjoyb commented 3 months ago

Awesomr work @bhuvangoel04 🚀 Please don't forget to Star the repository!

bhuvangoel04 commented 3 months ago

Thank you I always star a repository before forking it.