search

poorna-kumar / gendermeme-core

A first open-sourced version of GenderMeme: https://gendermeme.org/
MIT License
6 stars 1 forks source link

Output of get_article_info should be list, not dict #1

Closed aendra-rininsland closed 7 years ago

aendra-rininsland commented 7 years ago

Hi!

I've noticed get_article_info() outputs a dict and not a list, even though the dict keys are simply integers. Is there any reason why it couldn't be a list? Using a list is more powerful (easier to iterate over, esp. in JS) and idiomatic.

viswajithiii commented 7 years ago

Yes, this is a good point. The reason we made it a dict is so that the id was explicit to a human who's reading the output, but there's no reason that get_article_info() shouldn't just return a list since the index is implicit anyway. We'll keep this in mind and push an update soon! Thanks for bringing this up.