search

poorna-kumar / gendermeme-core

A first open-sourced version of GenderMeme: https://gendermeme.org/
MIT License
6 stars 1 forks source link

Fixes Python3 compatibility; adds setup.py #10

Open aendra-rininsland opened 5 years ago

aendra-rininsland commented 5 years ago

This should enable gendermeme-core to work in Python3 environments (as well as maintain compatibility with Python2.5+).

It also adds a rudimentary setup.py file to enable gendermeme to be submitted to and installed from PyPI.

viswajithiii commented 5 years ago

Hi @aendrew, what is the status of the changes on this branch? Does GenderMeme work in Python3 now with these changes, or is there more stuff to be done?

If it works, feel free to merge it in!

If it isn't there yet: @poorna-kumar and I are planning to do a GenderMeme hackathon next weekend. Upgrading to Python3 was on our list, so if there's more to be done, we're happy to take a stab at it over next weekend to see if we can get it to work.

aendra-rininsland commented 5 years ago

@viswajithiii I just got this code working in production in Python 3 on Friday, but I don't know if I've broken anything in Python 2 in the process (shouldn't have!).

If you wouldn't mind pulling the branch and running a few tests on it in Python 2 I'd really appreciate that before squashing/merging. 👍

viswajithiii commented 5 years ago

Sounds good, @aendrew! We will do that.