search

poorna-kumar / gendermeme-core

A first open-sourced version of GenderMeme: https://gendermeme.org/
MIT License
6 stars 1 forks source link

Quote attribution: Consider switching to new version of CoreNLP? #8

Open poorna-kumar opened 6 years ago

poorna-kumar commented 6 years ago

https://stanfordnlp.github.io/CoreNLP/quoteattribution.html This might be a new feature of the next version of CoreNLP.

aendra-rininsland commented 5 years ago

I'm trying to get it to work with 3.9.x and failing miserably. The Quote and DepParse annotators aren't compatible, try running them at the same time. As is I'm going to have to downgrade.

See: https://github.com/stanfordnlp/CoreNLP/issues/799

That said, if the new functionality in the Quote annotator leads to using fewer other annotators (and can be used exclusively of DepParse) it might be worthwhile?

viswajithiii commented 5 years ago

Wow, that's strange, @aendrew. Thanks for filing the issue with CoreNLP!

I believe we use dependency parses for purposes other than helping with quote annotation, so I'm not sure if we can do without it -- we'll look into this, though. We also need to investigate whether the new quote attribution stuff improves our accuracy (it certainly looks like it should!).

I suppose in the worst case we could make two separate requests to the CoreNLP server and combine the annotation results in GenderMeme code -- although that's not ideal.