pootlepress / caxton

Gutenberg pro
GNU General Public License v2.0
24 stars 6 forks source link

CSS styles on `.h1` selector #183

Open ethanclevenger91 opened 4 years ago

ethanclevenger91 commented 4 years ago

The following CSS is being applied once the plugin is activated:

.h1 {
    height: 1rem;
}

Anyone using Bootstrap classes is going to suddenly find their top-level headings visually broken. Prefix your selectors, please.

shramee commented 4 years ago

Thanks for raising the issue @ethanclevenger91, This is from atomic CSS framework Tachyons which we include as a part of Caxton. We will investigate how much of the framework we are using and possibly reduce high probability conflicting parts (like .h1). We are unable to prefix all classes unfortunately, however thanks to the atomic nature of classes (like .tc, .pa3, etc. More at http://tachyons.io/docs/) it might not conflict much.

Please follow #185 For more on this.

ethanclevenger91 commented 4 years ago

I just checked out Tachyon source because I thought it was weird they would assign a height to headings but that literally means "height 1", and has nothing to do with headings. That's...a decision. Thanks for looking into this.

On Mon, Jun 8, 2020 at 12:07 AM Shramee Srivastav notifications@github.com wrote:

Thanks for raising the issue @ethanclevenger91 https://github.com/ethanclevenger91, This is from atomic CSS framework Tachyons which we include as a part of Caxton. We will investigate how much of the framework we are using and possibly reduce high probability conflicting parts (like .h1). We are unable to prefix all classes unfortunately, however thanks to the atomic nature of classes (like .tc, .pa3, etc. More at http://tachyons.io/docs/) it might not conflict much.

Please follow #185 https://github.com/pootlepress/caxton/issues/185 For more on this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pootlepress/caxton/issues/183#issuecomment-640411193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUARHUD5YNRLD6GLVLHKMDRVSE2DANCNFSM4NNKG27Q .