search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Dropdown colors #11

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

The header bg color should also be applied to dropdowns to avoid this (http://cl.ly/image/1W232b0C2g3g). You can use storefront_adjust_color_brightness() to make the dropdown a slightly darker shade of the general header bg color.

shramee commented 9 years ago

Didn't use - storefront_adjust_color_brightness(), we have a simpler and better performing method - to give its children a rgba black with alpha 0.05.

shramee commented 9 years ago

Missed WooCommerce cart dropdown in Commit above including it in next commit.

nickburne commented 9 years ago

I think storefront_adjust_color_brightness() is a better solution.

nickburne commented 9 years ago

If we don't use this function then when WooThemes update Storefront in the future it could go wrong.

shramee commented 9 years ago

Hmmm... That could happen. Will get it changed today.

nickburne commented 9 years ago

Yep - we have to be thinking long term as we don't control the main theme (in this case storefront)

Thanks!

shramee commented 9 years ago

While using this function, an idea struck my mind, may be we should ask the user whether she would like to lighten or darken the color since if one wants jet black its not gonna work out well. And maybe we can provide her with options for brightness adjustment (a spinner control should do). Let me know, set to darken right now.

nickburne commented 9 years ago

I think it should just do want the theme does as standard right now (which as I understand it) is do this automatically. We don't want more options for users at the moment...

shramee commented 9 years ago

Done, kindly check this out : )

shramee commented 9 years ago

Okay, maybe we can add it later.

nickburne commented 9 years ago

Yep - maybe. Right now, WooThemes want to keep options to a minimum to reduce developement and support overhead. I agree with them. Will test this out when I test everything.

nickburne commented 9 years ago

Ok - the way the colors work on the per post/page/product settings are not exactly the same as the existing global options in WP Customizer.

The color looks slightly different and the hover text behaviour is not exactly the same. This should be exactly the same.

See pics...

screenshot 2015-03-20 15 20 23 screenshot 2015-03-20 15 20 46

shramee commented 9 years ago

Respected Sir, This is my humble request to check if this issue is solved.

Yours Sincerely Shramee

nickburne commented 9 years ago

Ok - looks good to me...