search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Background image and color option #20

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

Hi Shramee,

Ok, we also need to add a background image and color option per page, post and product as well as taxonomies (tag, categories for each)

There are already default global options in the WP Customizer for Storefront.

Thansk!

N

shramee commented 9 years ago

Taxonomies have now got the fields functioning properly but neither storing info in DB nor functioning in frontend.

shramee commented 9 years ago

Hey Nick, It's done, kindly check it out, lemme know if all is well ; )

nickburne commented 9 years ago

Cool. Will test tomorrow... N

Sent from my iPhone

On 23 Mar 2015, at 14:20, Shramee Srivastav notifications@github.com wrote:

Hey Nick, It's done, kindly check it out, lemme know if all is well ; )

— Reply to this email directly or view it on GitHub.

nickburne commented 9 years ago

Ok, a few issues.

  1. If background image is set as the global default and then I update the background color per page, post, product (including categories and tags) the background color should over-ride the global background image. This also goes for header background images.
  2. I don't really like the upload button of the image options being on the next line on the taxonomy edit pages
  3. I don't like the Page Customizer options being available when a new category or tag is created. Is it possible to just have the option on the category and tag edit screens?
shramee commented 9 years ago

Aaaww Yeah, Was waiting for reply since the morning think I'll send the work report again. ; )

shramee commented 9 years ago

For

I don't like the Page Customizer options being available when a new category or tag is created. Is it possible to just have the option on the category and tag edit screens?

Yes, We can.

nickburne commented 9 years ago

Ok - please go ahead and make it so.

nickburne commented 9 years ago
  1. Deafult Background image options in Customizer give more options when background image is uploaded. Can we do the same per page, post, product, category and tag?
shramee commented 9 years ago

Shout if I missed a point ; )

nickburne commented 9 years ago

That last point was meant to say '4'

shramee commented 9 years ago

Yeah man, I was about to say that we should have better image uploader. One we currently use is some wp 3.4 ( if I recall correctly ) we definitely must have the new one.

Shramee IBMwebs.com Sent from my iPhone

On 24-Mar-2015, at 10:56 pm, Nick Burne notifications@github.com wrote:

Deafult Background image options in Customizer give more options when background image is uploaded. Can we do the same per page, post, product, category and tag? — Reply to this email directly or view it on GitHub.

shramee commented 9 years ago

Aloha, Done, Kindly check it out, and kindly let me know if I should implement NEW wp image selector (kind of what we have in featured image). Cheers

shramee commented 9 years ago

Hey Nick, What's up? Hows it? Shall I...new uploader?

nickburne commented 9 years ago

I don't understand the difference between the new uploaders? I always want to be the most native to WordPress. Please explain...

shramee commented 9 years ago

Hi, Sharing some snaps Cheers

shramee commented 9 years ago

LHS our image selector and RHS Featured image selector imguplaoders

shramee commented 9 years ago

Selecting existing image on both of different image selectors (do you get it different than I do?) imguplaoders2

nickburne commented 9 years ago

I prefer the one on the RHS as it's what Storefront already uses in the WP Customizer so it's consistent...

shramee commented 9 years ago

Don't you get this in post SFX page customizer post uploader?? blah

nickburne commented 9 years ago

You mean when you click 'add media' on a post? If so, this is what I get...

screencapture-127-0-0-1-test1-wp-admin-post-new-php

shramee commented 9 years ago
Don't you get this in post SFX page customizer post uploader??

I mean don't you get media attachment for our sfx-pc like this?

shramee commented 9 years ago

BG and Header BG fields?

shramee commented 9 years ago

I'm talking about our image fields.

nickburne commented 9 years ago

Can you send me a screen shot with an arrow of the button you are clicking in posts?

shramee commented 9 years ago

Hmmm... From one of our windows pcs Just a while lemme borrow Keshav's PC ; )

shramee commented 9 years ago

uploaders Sorry for awful arrows : P

nickburne commented 9 years ago

ok - i would like to change them all to the new one (the RHS one) that is like the Storefront cusotmizer...

Thanks!

N

shramee commented 9 years ago

Shouldn't we have a new ticket for this? (gonna take about 15 mins I guess)

shramee commented 9 years ago

Sorry, it took so long actually last time I did it for apparel was with a single field, here we had multiple and that code kept on over righting the first field so... while testing... Anyways got it ready now : )

nickburne commented 9 years ago

Ok - will test soon.

nickburne commented 9 years ago

This is good! If I find any issues I will add as new ones. Well done!