pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Add a 'Hide Header widget area' checkbox option per page #24

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

Add a new option per page, post and product (a checkbox) to 'Hide Header widget area'.

There is no global default for this as it only appears when a user puts a widget into the widget area.

Any questions, let me know.

N

shramee commented 9 years ago

Well there are two ways of doing it according to me:

  1. Go ahead and display none the header widget section - Quick
  2. Go through the storefront theme to see if the widget section HTML code can be removed - Better performance but time taking and extra time taken might be useless (if we find that display block is only option) I think we should go with 2, whaddya say?
shramee commented 9 years ago

Continuing on 2 till i hear from you ; )

nickburne commented 9 years ago

Why is 2 better performance?

shramee commented 9 years ago

The page load time will be reduced since the widget might contain images or other heavy stuff.

shramee commented 9 years ago

Like the widget could be our Blog Widget with 5 posts and featured images!!

shramee commented 9 years ago

Yeah baby!! /* * @hooked storefront_header_widget_region - 10 / do_action( 'storefront_before_content' ); ?>

shramee commented 9 years ago

We can do it the efficient way ; )

nickburne commented 9 years ago

Ok - forget this option, Jamie has just come up with another way customers can do it easily, so forget it...

N

shramee commented 9 years ago

Well just to say, I got 80% work done and now I gotta discard that code ??

shramee commented 9 years ago

Are you sure you want me to remove all code?

shramee commented 9 years ago

Ten minutes and this is done.

nickburne commented 9 years ago

Yes - remove all code. We don't need it.

shramee commented 9 years ago

Okay