search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

White screen of death problem #36

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

Jamie gets a white screen of death.

We think it is a PHP version issue. It works ok for me on 5.3

Can you test down to 5.2.4 please?

https://wordpress.org/about/requirements/

nickburne commented 9 years ago

I think I have found the issue. Now if WooCommerce is not installed (e.g. on a fresh install) I get this...

Fatal error: Call to undefined function is_shop() in /Applications/AMPPS/www/test11/wp-content/plugins/sfx-page-customizer-master/sfx-page-customizer.php on line 567

nickburne commented 9 years ago

Needs to work without WooCommerce being installed.

shramee commented 9 years ago

Hmmm... Let me know if he can access wp-admin file and change something like wp_debug to true (will be false by default)

shramee commented 9 years ago

Oh thanks

shramee commented 9 years ago

Lemme get it right

shramee commented 9 years ago

Sorry didn't read Fatal error: Call to undefined function is_shop() in /Applications/AMPPS/www/test11/wp-content/plugins/sfx-page-customizer-master/sfx-page-customizer.php on line 567

nickburne commented 9 years ago

Let me know when fixed...

shramee commented 9 years ago

Done

shramee commented 9 years ago

There were two places it happened!

shramee commented 9 years ago

Should have used function_exists() will take care next time.

nickburne commented 9 years ago

Still get this: Fatal error: Call to undefined function is_shop() in /Applications/AMPPS/www/test11/wp-content/plugins/sfx-page-customizer-master/sfx-page-customizer.php on line 567

I'm on new install without WooCommerce and PHP 5.3

nickburne commented 9 years ago

Is this fixed yet?

shramee commented 9 years ago

I guess I did it but lemme see once again.

shramee commented 9 years ago

Hmmm... this happens on archive page for me, lemme see how I can work through this since I've got lots of && in this if statement.

shramee commented 9 years ago

Now created a variable $is_shop which is only true if is_shop is set and is_shop is true. Lemme just see if it works for shop now.

shramee commented 9 years ago

Bulletproof now ; )

shramee commented 9 years ago

Works for the shop page as well.

nickburne commented 9 years ago

Ok - works for me...

shramee commented 9 years ago

Great