issue with hiding breadcrumbs

[nickburne]

when woocommerce is installed with storefront it puts breadcrumbs on posts, pages and products.

When the user hides breadcrumbs it removes too much space... Is there a way when users remove breadcrumbs that it leaves the same space between the header and page title as when woocommerce is not installed?

[nickburne]

Now with Woocommerce not installed...

[shramee]

I'm not able to imitate this even with woo commerce deactivated.

[nickburne]

Ok - activate woocommerce and create a post. On the post page you should see breadcrumbs. Hide the breadcrumbs and check it out.

Then de-activate woocommerce and check the post page again.

[shramee]

Thanks, let me see.

[shramee]

Errrr, Still couldn't do it.

[shramee]

What I can see on taking a closer look is that the space is a result of margin-bottom: 4.236em; on header-widget-section.

[shramee]

Errrr, Still couldn't do it.

Means I still couldn't imitate the issue

[nickburne]

We need you to re-create the issue. This was a new install with the new version of Storefront. What version of Storefront do you have installed. Newest version is 1.4.2

[shramee]

Uhmmm... I got 1.2.5, updating

[shramee]

Thanks bud, Got it, fixing...

[shramee]

Do we need to take care of old version too?

[shramee]

No problemmo, found the best way, add no-wc-breadcrumb clas to the body and rest is done by storefront!! Cool ain't it?

[shramee]

Kindly check this one out too. I believe its the best to be intermingled with storefront and avoid creating custom functionality and use default storefront where ever possible, Whaddya say (future issues will be solved based on your reply ; ) )?

[nickburne]

Definitely - we should always keep as close to the theme as possible...

Thanks!

N

[shramee]

Its done.

[nickburne]

thanks!

[shramee]

My pleasure.

[nickburne]

Nice work!