search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Custom fields being filled in on WooCommerce products... #43

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

Why is this?

screencapture-127-0-0-1-test12-wp-admin-post-php

shramee commented 9 years ago

This is going to happen on enabling Custom Fields in screen options. customfieldscreenoptions

nickburne commented 9 years ago

But page customizer shouldn't put custom fields into woocommerce products...

Why would it do this?

shramee commented 9 years ago

This is going to happen for any custom field not appended by an underscore ( WP recognizes fields prepended by an underscore private ).

shramee commented 9 years ago

So we can simply prepend our fields with an underscore.

shramee commented 9 years ago

This would happen for all post types alike

shramee commented 9 years ago

Should we append with an underscore?

shramee commented 9 years ago

Sorry prepend with an underscore?

shramee commented 9 years ago

Yep just tested doesn't show now that I've prepended an _, should I commit this?

nickburne commented 9 years ago

Yes please!

shramee commented 9 years ago

Done, but the preexisting fields will still be displayed (prior to this commit).

shramee commented 9 years ago

Kindly lemme know if its all right.

nickburne commented 9 years ago

Yep - better!