search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Weird tabs when woocommerce installed #48

Closed nickburne closed 9 years ago

nickburne commented 9 years ago

This pic is taken on edit product page...

screenshot 2015-04-08 15 30 54

shramee commented 9 years ago

Yeah this happens with our page customizer also.

shramee commented 9 years ago

Will start shortly...

shramee commented 9 years ago

On this one now.

shramee commented 9 years ago

WooCommerce uses jQuery UI css via CDN, It's not available with WordPress but I just want those lovely styles!!!

shramee commented 9 years ago

screenshot - wednesday 08 april 2015 - 08 45 09 ist

These look way more sexy than ours can we keep these?

shramee commented 9 years ago

Done these for now lemme know if we need something simpler (like we had earlier).

nickburne commented 9 years ago

Do you have an example of Woocommerce using this?

shramee commented 9 years ago

Nope, But WooCommerce en-queues jQuery UI styles css file.

nickburne commented 9 years ago

Ok - we would have to use our own version of the WooCommerce way in case customers want to use it without WooCommerce. Correct?

shramee commented 9 years ago

I just enqueued the jqUI file for default styles...

shramee commented 9 years ago

...and comment our styles

shramee commented 9 years ago

Should I just restore our old styles and do something so that styles don't conflict with jquery ui?

shramee commented 9 years ago

Right now even if wooCommerce is not installed jqUI css will be enqueued.

shramee commented 9 years ago

The best part is that we didn't add any new file but enqueued via jquery CDN (like wooCommerce)

nickburne commented 9 years ago

ok - i'm happy with this. Please committ and confirm it's done.

shramee commented 9 years ago

Aye

shramee commented 9 years ago

Done