Make options work on WooCommerce product pages

[nickburne]

Currently Storefront page customizer works on pages and posts. We would also like the options to work on WooCommerce product pages (which are a custom post type)

[nickburne]

It is good to see that some files have been committed. Now please remove the files by uncommitting the committ:

https://github.com/jamiemarsland/sfx-page-customizer/commit/04a6e3d245f7deb4eb09afe2635428cda2af41e6

Then please adapt the existing files to solve this issue.

As above this issue is: "Currently Storefront page customizer works on pages and posts. We would ALSO like the options to work on WooCommerce product pages (which are a custom post type)"

This is an additional feature of this existing plugin that needs to be developed. Once this new enhancement has been developed please commit and in the commit title link it to this issue number.

Thanks,

Nick

[nickburne]

Ok - this is good.

There is one issue where hiding the title on a product page also cuts off the text underneath... please fix.

[shramee]

I would like to know if we only want to hide the titles ONLY at resolutions more than 768px (Desktop and large Tabs) coz at resolutions less than title is shown up again.

[shramee]

Ahoy, Made an amendment to my above Question. :P Kindly let me know if this is the case, I can see the style enveloped in @media screen and (min-width: 768px) { AND }

[shramee]

Done, didn't remove @media screen and (min-width: 768px) { stuff yet, moving to next one. Kindly check this babe out and lemme know. Cheers

[nickburne]

For the moment, please remove for both desktop AND mobile... thanks!

[shramee]

Nick, Lemme explain it again,

[shramee]

The stuff (css) responsible for hiding and showing the page titles is enveloped in media query mentioned as a result, hide title only works on resolutions more than 768px wide. Are you sure you want me to remove the CSS altogether, or you want me to remove the css media queries to make hide title work for all resolutions ( Try hide title on a narrow window, you will find it doesn't work on narrow screen widths ).

[shramee]

Also kindly let me know where are you located so that I have an idea when you would be available in the case of queries.

[shramee]

Not only hiding the title, but change header color and image also doesn't work on resolutions less than 768px.

[shramee]

For now I'm going with the most probable answer (according to me) to remove media queries, since we definitely want that functionality and I guess its better to keep it effective for all resolutions. Let me know if its all right ;)

[nickburne]

yes - that is right.

I am now in Japan but about to fly to South Korea... ; )

[shramee]

And is that all right to remove the media query?

[shramee]

Forgot to assign you last time. :P

[nickburne]

Yes, it's good! Just nee to test before closing the ticket...

Sent from my iPhone

On 11 Mar 2015, at 12:53, Shramee Srivastav notifications@github.com wrote:

Forgot to assign you last time. :P

— Reply to this email directly or view it on GitHub.

[shramee]

Okay cool Cheers

[nickburne]

Works well! Thanks!