search

pootlepress / sfx-page-customizer

Page Customizer for Storefront
0 stars 0 forks source link

Upload header background image per page/post #7

Open nickburne opened 9 years ago

nickburne commented 9 years ago

This option should work just how the option in the WordPress customizer works.

Specifically at the upload image option for global header background image in the WP Customizer offers the user the ability to crop the image. See pic.

Please ammend the per page/post option for background image to offer the same ability for users to crop the image.

screenshot 2015-03-04 12 25 17

Thanks,

Nick

shramee commented 9 years ago

This is gonna be fun!!!

nickburne commented 9 years ago

How are you getting on with this one??

shramee commented 9 years ago

Hmm... Its a WP customizer class only for header images not specific to storefront, it is WP functionality used in several themes for instance stock 2015 theme, Unfortunately its not modular like other WP features but a chunk of code which requires careful analysis and testing. Moreover its not documented nowhere so I'll have to carry on with browsing and analyzing WP core files and find a way to incorporate it in post meta.

shramee commented 9 years ago

Hi, Had been working on this since last couple of hours, Unfortunately, I couldn't find a way to integrate WP_Customize_Header_Image_Control class with post meta. However we can get this done via our own interface for cropping, lemme know if I should proceed with that.

shramee commented 9 years ago

Aaaawww... Today is Saturday.... So Will have to wait till Monday right..?..?? I guess so...

nickburne commented 9 years ago

I think we should leave this for now and reverse any code...

nickburne commented 9 years ago

Can you confirm that you have removed any code for this??

nickburne commented 9 years ago

@jordankeats - this is one for us to discuss...

shramee commented 9 years ago

Yep, Done.

nickburne commented 9 years ago

Ta

shramee commented 9 years ago

You're Welcome.

jordankeats commented 9 years ago

@nickburne - sounds good.

On Mar 16, 2015, at 3:12 AM, Nick Burne notifications@github.com wrote:

@jordankeats - this is one for us to discuss...

— Reply to this email directly or view it on GitHub.

nickburne commented 9 years ago

Leave for now (James K)