Styles: Use Sass variables to make it easier to change style in the future.

poowf / otter

A relatively automatic CRUD backend administration panel for Laravel

MIT License

259 stars 17 forks source link

Styles: Use Sass variables to make it easier to change style in the future. #47

Closed earboxer closed 4 years ago

earboxer commented 5 years ago

Currently, CSS variables are not fully supported. Since we're already using SASS, might as well take advantage of some of their features!

(Note: Please review and merge in https://github.com/poowf/otter/pull/46 first so that the diff here is easier to review)

zanechua commented 5 years ago

Hah. nice job. This was something I intended to do as I know there's quite a bit of duplicate code between the styles. But if this builds fine locally then I think I'm good to merge this in.

earboxer commented 5 years ago

I haven't tested this recently, but given there are still no merge conflicts, I don't think much has changed that would necessitate re-testing.