search

poowf / react-native-argon2

MIT License
5 stars 8 forks source link

Unable to integrate to React Native 0.63 #1

Closed canpoyrazoglu closed 4 years ago

canpoyrazoglu commented 4 years ago

I'm trying to install react-native-argon2 to my React Native project, but I'm getting the following error in Pods installation:

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `RNArgon2` depends upon `Argon2`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

If I add use_modular_headers! as suggested, I get many other errors.

Here is my Podfile (with the new RN 0.63 spec):

require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

platform :ios, '10.0'

target 'MY_APP_NAME_REDACTED' do
  config = use_native_modules!

  use_react_native!(:path => config["reactNativePath"])

end
zanechua commented 4 years ago

Hello!

I'm sorry but I'm not sure how I missed your issue and I just saw it.

I have a project that's using this library on 0.63 and I'm not facing the issues you're facing.

Did you specifically add the Argon2 module to your Podfile as per the README?

canpoyrazoglu commented 4 years ago

Hi again!

Because of the time constraints, I had to switch to use an alternative library for the project. But when I was tring to get it work, I followed all the readme. I was getting different errors whenever I tried to use submodules, not use submodules, or anything that the error messages recommended me to do.

zanechua commented 4 years ago

Ah. No worries.

That's odd. I'll see if I can reproduce it on my end with a new 0.63 project.

Leaving this ticket open for now in the event that someone else faces the same issue or you remember something.

This is my current environment and Podfile which works for me.

info Fetching system and libraries information...
System:
    OS: macOS 10.15.6
    CPU: (16) x64 Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz
    Memory: 28.93 GB / 64.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.18.4 - /usr/local/bin/node
    Yarn: 1.22.5 - /usr/local/bin/yarn
    npm: 6.14.8 - /usr/local/bin/npm
    Watchman: Not Found
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 14.0, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK:
      API Levels: 28, 29, 30
      Build Tools: 28.0.3, 29.0.2, 30.0.2
      System Images: android-28 | Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-30 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 4.0 AI-193.6911.18.40.6626763
    Xcode: 12.0.1/12A7300 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_242-release - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: ^4.13.0 => 4.13.0
    react: 16.13.1 => 16.13.1
    react-native: 0.63.3 => 0.63.3
  npmGlobalPackages:
    *react-native*: Not Found

Podfile:

platform :ios, '10.0'
require_relative '../node_modules/react-native/scripts/react_native_pods'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'project' do
  config = use_native_modules!

  use_react_native!(:path => config["reactNativePath"])

  pod 'Argon2', git: 'https://github.com/signalapp/Argon2.git', submodules: true
  pod 'GoogleIDFASupport', '~> 3.14.0'

  target 'projectTests' do
    inherit! :complete
    # Pods for testing
  end

  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable these next few lines.
  use_flipper!

  post_install do |installer|
    flipper_post_install(installer)
  end
end

target 'project-tvOS' do
  # Pods for project-tvOS

  target 'project-tvOSTests' do
    inherit! :complete
    # Pods for testing
  end

end
tbrent commented 4 years ago

I was able to get this working in my react-native 0.63 project without problem, though at the moment this is just on the android side.

zanechua commented 4 years ago

Someone in the team recently faced this issue and was on CocoaPods v1.9.1.

We resolved the issue by doing the following:

If you still face the issue, please comment back or create a new issue.