pooyamb / serde-querystring

A query string parser for rust with support for different parsing methods
Apache License 2.0
10 stars 3 forks source link

Making the axum extractor more idiomatic #2

Open si14 opened 1 year ago

si14 commented 1 year ago

I noticed that the current axum extractor diverges from the official Query design: https://docs.rs/axum/0.6.13/src/axum/extract/query.rs.html#51-65

In particular, I think two things can be done to make it a bit more idiomatic:

What do you think of those changes? If you're happy with them, I might make a stab at a PR implementing that.

pooyamb commented 1 year ago

Hi @si14 ,

I agree with you on both points, For the custom rejection part, I personally prefer to just copy and modify axum's extractors, so I wasn't sure what was more idiomatic, and I gladly would accept a PR for it.

For the parsing method part, what names do you suggest for these new extractors?