Closed mmstick closed 5 years ago
@cassidyjames Truth be told, I've no idea how all the appstream stuff works on Debian. What would be the best course of action for getting appstream data working with the Pop!_Shop?
It shows up now! I'm thinking we probably should include a screenshot though.
Are we happy with the description? (@cassidyjames )
@brs17 to include a screenshot, we have to upload and commit to hosting one somewhere. Which is fine, we just have to coordinate with @btkostner or something.
I agree the copy could use some work. I'll write something up.
My thought is if we are putting our name next to something (which we are) it should be done well. I don't see this as a pressing pr so I think it makes sense to take some time and make it better.
I think we should have screenshots of each view, as well as a better description.
Screenshots in appstream data shipped this was is apparently a pain. @btkostner says there's some work we can do, but it involves a lot more than just sticking a URL in the data.
I've taken a bunch of HiDPI screenshots with shadows and everything for whenever we figure out where to put them. I've also updated the description.
Can you run build so the dest folder is updated? Then I think this is ready
@brs17 thoughts?
Do we want to add a "Report a Problem" link that would point to https://github.com/pop-os/popsicle/issues ?
The screenshots appear to be a little lower resolution than is probably ideal.
Also in the description of the application has the html visible:
<p>Write an ISO or other image to multiple USB devices all at once. Easily preparing a bunch of flash drives of your favorite OS with just a couple of clicks.</p> <ul>
<li>Supports USB 2 and 3 devices</li>
<li>Use USB hubs for massively parallel writing</li>
<li>Verify your image with the SHA256 or MD5 checksum</li>
<li>Check the progress, speed, and success of each device while flashing</li>
<li>Open ISO or IMG files from the app, or straight from your file manager</li>
<ul>
This is a screenshot of what I see on the current commit (bdf2db):
Somehow doesn't seem to include the fixes for the issues I mentioned earlier. Those fixes should add the issues page link as well as remove the tags from the description.
In regards to the screenshots, I still think they look a little blurry and I am wondering if those screenshots are taken on a hidpi screen if they would appear crisper.
Seems I edited the wrong file.
You can take the screenshots on a HiDPI display, or simply use the GTK inspector to force 2x scaling. In the past, I also used the elementary screenshot tool for higher-quality screenshots that include the window shadow exactly as defined by the GTK stylesheet as well.
@mmstick Let's add better quality screenshots and then I'll review
HiDPI screenshot
@mmstick , looks like in your latest change we lost the icon for popsicle.
It also looks like the Help
button links to the issues page. I would expect Report a Problem
to link there. Not sure we have a good page to link Help
to right now.
Not going to worry about improved screenshots here as that should be a pr into Popsicle itself.
With that latest commit, I believe we can/should merge this. @mmstick can you confirm the links at the bottom of the popsicle page work as expected?
Sure. I'll check it out in the morning.
Closes https://github.com/pop-os/popsicle/issues/43