pop-os / appstream-data

Additional appstream data to be shipped in Pop!_OS
4 stars 5 forks source link

Add Popsicle #5

Closed mmstick closed 5 years ago

mmstick commented 6 years ago

Closes https://github.com/pop-os/popsicle/issues/43

mmstick commented 6 years ago

@cassidyjames Truth be told, I've no idea how all the appstream stuff works on Debian. What would be the best course of action for getting appstream data working with the Pop!_Shop?

brs17 commented 6 years ago

It shows up now! I'm thinking we probably should include a screenshot though.

Are we happy with the description? (@cassidyjames )

screenshot from 2018-06-26 15-10-56

cassidyjames commented 6 years ago

@brs17 to include a screenshot, we have to upload and commit to hosting one somewhere. Which is fine, we just have to coordinate with @btkostner or something.

I agree the copy could use some work. I'll write something up.

brs17 commented 6 years ago

My thought is if we are putting our name next to something (which we are) it should be done well. I don't see this as a pressing pr so I think it makes sense to take some time and make it better.

mmstick commented 6 years ago

I think we should have screenshots of each view, as well as a better description.

cassidyjames commented 6 years ago

Screenshots in appstream data shipped this was is apparently a pain. @btkostner says there's some work we can do, but it involves a lot more than just sticking a URL in the data.

cassidyjames commented 6 years ago

I've taken a bunch of HiDPI screenshots with shadows and everything for whenever we figure out where to put them. I've also updated the description.

jackpot51 commented 5 years ago

Can you run build so the dest folder is updated? Then I think this is ready

jackpot51 commented 5 years ago

@brs17 thoughts?

brs17 commented 5 years ago

Do we want to add a "Report a Problem" link that would point to https://github.com/pop-os/popsicle/issues ?

The screenshots appear to be a little lower resolution than is probably ideal.

Also in the description of the application has the html visible:

<p>Write an ISO or other image to multiple USB devices all at once. Easily preparing a bunch of flash drives of your favorite OS with just a couple of clicks.</p> <ul>
  <li>Supports USB 2 and 3 devices</li>
  <li>Use USB hubs for massively parallel writing</li>
  <li>Verify your image with the SHA256 or MD5 checksum</li>
  <li>Check the progress, speed, and success of each device while flashing</li>
  <li>Open ISO or IMG files from the app, or straight from your file manager</li>
<ul>
brs17 commented 5 years ago

This is a screenshot of what I see on the current commit (bdf2db):

popsicle

Somehow doesn't seem to include the fixes for the issues I mentioned earlier. Those fixes should add the issues page link as well as remove the tags from the description.

In regards to the screenshots, I still think they look a little blurry and I am wondering if those screenshots are taken on a hidpi screen if they would appear crisper.

mmstick commented 5 years ago

Seems I edited the wrong file.

cassidyjames commented 5 years ago

You can take the screenshots on a HiDPI display, or simply use the GTK inspector to force 2x scaling. In the past, I also used the elementary screenshot tool for higher-quality screenshots that include the window shadow exactly as defined by the GTK stylesheet as well.

brs17 commented 5 years ago

@mmstick Let's add better quality screenshots and then I'll review

isantop commented 5 years ago

popsicle-hidpi_screenshot_appdata

HiDPI screenshot

brs17 commented 5 years ago

@mmstick , looks like in your latest change we lost the icon for popsicle.

screenshot from 2018-10-12 12-07-30 screenshot from 2018-10-12 12-07-43

It also looks like the Help button links to the issues page. I would expect Report a Problem to link there. Not sure we have a good page to link Help to right now. screenshot from 2018-10-12 12-07-38

brs17 commented 5 years ago

Not going to worry about improved screenshots here as that should be a pr into Popsicle itself.

brs17 commented 5 years ago

With that latest commit, I believe we can/should merge this. @mmstick can you confirm the links at the bottom of the popsicle page work as expected?

mmstick commented 5 years ago

Sure. I'll check it out in the morning.