pop-os / cosmic-applets

WIP applets for cosmic-panel
GNU General Public License v3.0
214 stars 82 forks source link

[App list] Context menu GPU selection using too much space #233

Closed git-f0x closed 8 months ago

git-f0x commented 8 months ago

screenshot-2024-02-16-10-38-32

GNOME Settings uses a more compact name for GPUs (e.g. AMD Radeon RX 570 series), so this could also be changed for COSMIC Settings.

Drakulix commented 8 months ago

These names are currently provided by switcherooctl, which doesn't allow us to get much shorter ones. I have plans to switch away from switcheroo at some point, but I think the core issue here is, that the popup should size itself properly to accommodate for all it's entries.

wash2 commented 8 months ago

This issue should be fixed by the tiling update PR, which includes an updated version of libcosmic / iced that fixes authorized surfaces

git-f0x commented 8 months ago

The latest commit seems to have fixed this, though I'm not sure if the other Firefox options from the library are supposed to show up on the app list. screenshot-2024-02-20-17-15-11 screenshot-2024-02-20-17-15-20

Though now all applets (except the app library button, workspaces button and workspaces) are extremely sluggish (open about 1 second after a click, including the menu in the app list), and any changes to their placement on the panel causes the panel to disappear for almost 10 seconds. It also takes about that long for the panels to show up on boot.

wash2 commented 8 months ago

Hmm I can't seem to replicate the issue where the panel and applets behave very sluggishly. It does take some time for it to restart applets after they have changed, but I guess I could make it just reorder applets instead of restart them when possible on change. Do you have any logs that might be relevant?

git-f0x commented 8 months ago

Should I do journalctl -e _COMM=cosmic-session or something else?

wash2 commented 8 months ago

Ya that might work , or even just run cosmic-panel from terminal and send the output to a file. Though, I did that myself just now, and I think the culprit might be a bunch of logs being produced when the applets start.

git-f0x commented 8 months ago

Output of journalctl -e: journalctl.txt Seems to have a lot of logs from applets/panel.

Should I close this issue?

wash2 commented 8 months ago

Should I close this issue?

I think the original issue of the names being too long still exists, but ya the button isn't squished anymore, so it's up to you I guess :sweat_smile: . You could make a new issue for the log spam if you'd like, but I'm working on a fix for that now.

git-f0x commented 8 months ago

Since @Drakulix said that it's planned to be changed at some point, there's no need to fill up the issue list with this. As for the log spam, if that fixes the issue on my end, there's no need for a new issue. :)

wash2 commented 8 months ago

238 will be merged as soon as the build succeeds :)