search

pop-os / cosmic-applets

WIP applets for cosmic-panel
GNU General Public License v3.0
190 stars 65 forks source link

[App List] Missing Icon for VLC(flatpak) #252

Closed jilv220 closed 5 months ago

jilv220 commented 5 months ago

Current

screenshot-2024-03-01-04-48-58

Expected

vlc showing the correct icon.

Issue

The freedesktop_desktop_entry crate parse the app_id as stem of pathname.
screenshot-2024-03-01-04-51-44

The TopLevelInfo of vlc is parsed as vlc
screenshot-2024-03-01-04-47-22

However, the stem of vlc(flatpak) is VLC
screenshot-2024-03-01-04-55-46

Solution

I am not sure whose responsibility is this. Does this count as an edge case or?

ryanabx commented 5 months ago

I believe this is related: https://github.com/pop-os/cosmic-applets/issues/194

This affects element too, as the reverse domain for it is im.riot.Riot

ryanabx commented 5 months ago

Perhaps there could be a fallback app ID which is gleaned just in case one app id isn't working? There's got to be somewhere where the appid matches something in the .desktop file...

jilv220 commented 5 months ago

Fixed by https://github.com/pop-os/libcosmic/pull/336#issue-2177863680