pop-os / cosmic-applets

WIP applets for cosmic-panel
GNU General Public License v3.0
190 stars 65 forks source link

regression: COSMIC Settings unable to launch from app list #280

Closed ryanabx closed 5 months ago

ryanabx commented 5 months ago

I believe this started since upgrading libcosmic: https://github.com/pop-os/cosmic-applets/commit/ed049b1269a101a63a38ce194349ffdc642a38a6

So far, this is the only app I can find to have this regression.

COSMIC Settings will not open from the app list applet, and doesn't have a highlight around it when mousing over. This is identical to the behavior that apps like Element had before the patch listed above.

This is the output of my .desktop file for COSMIC Settings:

cat /usr/share/applications/com.system76.CosmicSettings.desktop
[Desktop Entry]
Name=COSMIC Settings
Type=Application
Exec=cosmic-settings
Terminal=false
Categories=GNOME;GTK;
Keywords=Gnome;GTK;
OnlyShowIn=GNOME;Unity;COSMIC
Icon=org.gnome.Settings
StartupNotify=true
NoDisplay=true

When I open the app and check the toplevel info with the toplevel-list helper from cosmic-protocols, it does indeed show up as com.system76.CosmicSettings:

cargo run --example toplevel-list
Toplevel ObjectId(zcosmic_toplevel_handle_v1@4278190083)
    Title: Some("Desktop - COSMIC Settings")
    App ID: Some("com.system76.CosmicSettings")
    States: []
    Outputs: []
    Workspaces: []

To reproduce:

wash2 commented 5 months ago

Ahh the desktop file has NoDisplay=true. That needs to be removed.

ryanabx commented 5 months ago

phew, I was kind of worried because I thought I introduced a regression with my libcosmic changes :sweat: I was doing some investigating on my end to see if there was something weird going on

wash2 commented 5 months ago

Yup, thanks for catching this! It should be fixed now.