pop-os / cosmic-applets

WIP applets for cosmic-panel
GNU General Public License v3.0
177 stars 55 forks source link

[Power/Brightness] Integrate external monitor brightness controls #428

Open joewood9364 opened 2 months ago

joewood9364 commented 2 months ago

https://github.com/davidhi7/ddcci-plasmoid The above KDE plasmoid allows users to change external monitor brightness which is very useful but also not very easy to install and does not integrate into KDE's native brightness adjustment sliders.

Ideally brightness adjustment of monitors would be a native feature akin to laptop screen brightness adjustment - COSMIC having this functionality by default would be a welcome improvement over competing DEs.

ids1024 commented 3 weeks ago

This definitely would be nice to have.

We'd need to decide how to handle multiple brightness devices.

wiiznokes commented 3 weeks ago

I guess key bindings could trigger the display where the mouse is. And there could be an option to control all monitors at the same time

Quackdoc commented 3 weeks ago

I would like to personally see something like monitorian's controls on windows, except a bit more sleek, A single brightness control with a dropdown menu perhaps, drop down to control each monitor individually, and when not dropped down, a single slider to control the brightness of all monitors in relation to the brightness set by the individual sliders.

https://github.com/emoacht/Monitorian

monitorian for reference, in the readme they have a video showcasing it working

key bindings can be just for the "global" control in this case

ids1024 commented 3 weeks ago

I see ddcutil is also quite slow to get or set brightness or other settings. Apparently this is expected: https://www.ddcutil.com/faq

ddcutil spends 90% of its elapsed time in waits mandated by the DDC/CI protocol.

That may be awkward with a slider?

That also mentions a couple issues with certain monitors, unsurprisingly. Not sure how consistently to expect things to work with DDC/CI. Does any OS or desktop environment currently expose it prominently, by default, for all monitors that support it?

onlyreportingissues commented 3 weeks ago

I see ddcutil is also quite slow to get or set brightness or other settings. Apparently this is expected: https://www.ddcutil.com/faq

ddcutil spends 90% of its elapsed time in waits mandated by the DDC/CI protocol.

That may be awkward with a slider?

That also mentions a couple issues with certain monitors, unsurprisingly. Not sure how consistently to expect things to work with DDC/CI. Does any OS or desktop environment currently expose it prominently, by default, for all monitors that support it?

Maybe this is useful: https://github.com/daitj/gnome-display-brightness-ddcutil/issues/137

"Response times with ddcutil are slow - use DDCControl DBUS service if available"

ids1024 commented 3 weeks ago

So it can be faster if some persistent service keeps open a DDC connection? That may be doable.