Closed jokeyrhyme closed 4 months ago
Hmmm, it does look like enter is supposed to work according to libcosmic: https://github.com/pop-os/iced/blob/1d9bb7fdff21f71c06c04e0c70087a5a8b0bc99e/widget/src/button.rs#L547
Unlike upstream iced-rs which only handles mouse events: https://github.com/iced-rs/iced/blob/0.12.1/widget/src/button.rs#L327
Thanks for catching this issue. I believe it's a problem with the ApplicationButton
and GroupButton
introduced by the app library in its own event handling.
Hmm actually the group button seems to handle the Enter key fine
Howdie,
I noticed that I can type a few letters to filter apps, and then tab and arrow-key around to move some sort of highlight/focus outline around to the app I want, but pressing enter/return does not launch the app
Looking at the code, I think it's because only the press event on the button widget is wired up, but I would have thought that would include enter/return (and even space?): https://github.com/pop-os/cosmic-applibrary/blob/8df76d5d228759136156f5cd1fd728b1df956475/src/app.rs#L945
Is this the intended behaviour?
If you're okay with me raising a PR to fix this, is this likely to be a button issue over in libcosmic / iced? Or should this only be solved here?