pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
418 stars 51 forks source link

screencopy: Don't send `fail` after `ready` #456

Closed ids1024 closed 2 months ago

ids1024 commented 2 months ago

Cosmic-workspaces was having an issue when the compositor sent ready, failed, then stopped. This could be worked around client-side, but presumably the compositor should never send more than one failed/ready for a particular frame.

It seems cleaner to have FrameInner::fail as the only place that sends failed. So any checks can be there. I believe the logic there should be appropriate for every call.