pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
418 stars 51 forks source link

Apps that use cosmic-comp's headerbar are incosistent with the rest of apps #471

Closed nabrious0 closed 1 week ago

nabrious0 commented 2 months ago

COSMIC apps have colored window controls (according to system accent color) and when hovering over one, your cursor turns into a pointer.

screenshot-2024-05-09-18-40-15

Apps like Discord (Vesktop) or any app that relies on COSMIC's titlebar doesn't follow this (non-colored window control buttons and cursor state does not change on hover)

screenshot-2024-05-09-18-41-16

Also, when dragging a window, on COSMIC or GTK apps your cursor changes into the "Grab" variant, on these apps it does not.

Drakulix commented 1 month ago

Most likely cosmic-comp needs an update for it's libcosmic version again to match cosmic apps. Thanks for bringing this to my attention.

WatchMkr commented 1 month ago

Here's the header design for reference (icons/text are @on_bg_color at 75% 50% opacity) https://www.figma.com/file/SkAtS5qlVOGQC0n895AHzX/Design-System-(WIP)?node-id=12298-80459&mode=dev

(unfocused libcosmic apps don't currently match the design)

Drakulix commented 1 week ago

Partially fixed by https://github.com/pop-os/cosmic-comp/commit/3d58ec062da59add47ad5df705ef09fd680742e5.

Correctly applies libcosmic's stylings now, focused style includes colored icons though, even though the server-side decorations aren't supposed though. This is a libcosmic bug.