search

pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
476 stars 85 forks source link

Update `smithay`, with xwayland shell changes #478

Closed ids1024 closed 4 months ago

ids1024 commented 4 months ago

I see there's another breaking Smithay change (noticed this in https://github.com/pop-os/cosmic-comp/pull/477).

For some reason Xwayland clients don't seem to show up now...

ids1024 commented 4 months ago

Looks like the client does create the surface, xwayland shell surface sets the serial, and attach a buffer.

Maybe something relies on wl_surface being Some before it is?

ids1024 commented 4 months ago

Updated for more Smithay changes. The Cow stuff is a bit annoying to deal with.

Xwayland still isn't working here.

Drakulix commented 4 months ago

XwmHandler::map_window_notify isn't called anymore, working on it.

Drakulix commented 4 months ago

Should be fixed by https://github.com/Smithay/smithay/pull/1436

Tipcat-98 commented 4 months ago

On cosmic-comp-4f076e0 I still get cosmic-comp crashes with certain xwayland apps and empty windows on others (only the title bar shows).

With error messages like: May 21 21:23:44 tipcat cosmic-comp[6140]: Failed to handle X11 event

I'm on Nvidia

If you'd like to test: Path of Building: Empty Window Discord in X11 mode: cosmic-comp crash

gabriele2000 commented 4 months ago

Agreed, Steam, for example, doesn't show up anymore. Running on a laptop, hybrid Intel+Nvidia GPU setup