search

pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
476 stars 85 forks source link

Reduce SSD height and account for height in X11 dialogs #502

Closed WatchMkr closed 4 months ago

WatchMkr commented 4 months ago

Reduce height to 36 pixels. Design is here at the bottom.

Account for the SSD height in X11 dialogs image (5)

Looking at xprop and xwininfo, I see the geometry of the window has 48 pixels less height than the minimum/maximum size requested by the client. So yeah, that's SSD_HEIGHT.

https://github.com/pop-os/cosmic-comp/blob/dfb3bea595425201cc00643e60f2827ffd33ac61/src/shell/element/surface.rs#L417 is supposed to account for that, but I guess it's somehow not working for Xwayland surfaces.

WatchMkr commented 4 months ago

SSD height is also mentioned in issue https://github.com/pop-os/cosmic-comp/issues/395 and adds a screenshot of Spotify being cut off. I haven't been able to reproduce normal X11 app windows... just dialogs.

ids1024 commented 4 months ago

I haven't been able to reproduce normal X11 app windows... just dialogs

This doesn't happen with most windows, since most are designed to be resizable and handle different sizes.

The dialog here, however, tries to required an exact width and height, then is given less height than it requested. And can't render properly.