pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
418 stars 51 forks source link

Fixes for handling of SSDs in window geometry #513

Closed ids1024 closed 1 month ago

ids1024 commented 1 month ago

This seems to fix the issue described in https://github.com/pop-os/cosmic-comp/issues/502 with XWayland dialogs not being allocated enough height.

This may also fix https://github.com/pop-os/cosmic-comp/issues/468, or that could be a similar issue. That will need more testing. If comic-comp gets the geometry of a window then calls set_geometry, if everything isn't perfectly symmetric that may lead to the sizing shrinking or growing like that.

ryanabx commented 1 month ago

Can you also look into the first part of #502, if in another MR if needed?

Edit: probably requires https://github.com/pop-os/libcosmic/pull/471#issuecomment-2134391238