search

pop-os / cosmic-comp

Compositor for the COSMIC desktop environment
GNU General Public License v3.0
475 stars 85 forks source link

libcosmic type leak since cbca13803cb499786b080ea9e4ee74cd4f704556 #543

Closed flukejones closed 3 months ago

flukejones commented 3 months ago

Can't build since 7b793875797f15c0c6715409104457b337d168bc due to:

   Compiling libcosmic v0.1.0 (https://github.com/pop-os/libcosmic/#9af083e0)
error[E0446]: restricted type `menu_inner::Direction` in public interface
  --> /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_bar.rs:34:5
   |
34 |     pub(crate) horizontal_direction: Direction,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak restricted type
   |
  ::: /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_inner.rs:75:1
   |
75 | pub(super) enum Direction {
   | ------------------------- `menu_inner::Direction` declared as restricted

error[E0446]: restricted type `menu_inner::Direction` in public interface
  --> /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_bar.rs:35:5
   |
35 |     pub(crate) vertical_direction: Direction,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak restricted type
   |
  ::: /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_inner.rs:75:1
   |
75 | pub(super) enum Direction {
   | ------------------------- `menu_inner::Direction` declared as restricted

error[E0446]: restricted type `MenuState` in public interface
   --> /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_bar.rs:36:5
    |
36  |     pub(crate) menu_states: Vec<MenuState>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak restricted type
    |
   ::: /home/luke/.cargo/git/checkouts/libcosmic-b367e32ffc370f4f/9af083e0c506/src/widget/menu/menu_inner.rs:292:1
    |
292 | pub(super) struct MenuState {
    | --------------------------- `MenuState` declared as restricted
flukejones commented 3 months ago

I'm actually not sure which commit caused this now this now..

ids1024 commented 3 months ago

The issue seems to just be the rustc version in rust-toolchain.toml.

CI passes because the pop-os build is using the version of Rust packaged in pop-os instead of rustup.

jrapf32 commented 3 months ago

I know what commit caused this

jrapf32 commented 3 months ago

https://github.com/pop-os/libcosmic/commit/59a913c15d8235eb9a8e73db2f6970efe4f50285#diff-c2c94ba3066c4dbf9d646338a8e8c7986c339859f7f227fa325f5676b54c96ae (I think)

Drakulix commented 3 months ago

Fixed with toolchain update